[react] store transform callback in useRef #1171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTML already prevents this by default, no need for custom logic after all
* add global visit options hook
Update axios version
mrmonat
changed the title
|
I ran into the same issue and can confirm that this fixes the issue. |
|
Can we please put priority on this pull request? It's not great the documented transform feature just 100% does not work at all for this long with an active fix available |
|
Is there no update on this PR? |
|
This looks like it needs rebasing as it has a bunch of other unrelated changes in it |
|
This is a huge update! Can confirm this is working as expected. How can we get this merged? These are the only changes which are needed: |
|
#1491 is newer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #1131
I think because the old implementation did not persist the callback between renders, the transform method of the form helper had no effect (was reset to default
(data) => datacallback) when called like shown in the example in issue #1131