-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support headerless format in getFrameParameters and decompress #217
base: main
Are you sure you want to change the base?
Conversation
@@ -767,7 +767,7 @@ def test_data_equivalence(self, original, threads, use_dict): | |||
dctx = zstd.ZstdDecompressor(**kwargs) | |||
|
|||
for i, frame in enumerate(result): | |||
self.assertEqual(dctx.decompress(frame), original[i]) | |||
self.assertEqual(dctx.decompress(frame.tobytes()), original[i]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the rust backend the test was erroring out becase frame
wasn't a buffer but a zstandard.backend_rust.BufferSegment
- not sure what the best way to fix it is...
This does work, so I added the conversion
[target.aarch64-apple-darwin] | ||
rustflags = ["-C", "link-arg=-undefined", "-C", "link-arg=dynamic_lookup"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For compiling on M1
Adding support for magic-less format in a few functions:
format
to get_frame_paramaters and switch to usinggetFrameHeader_advanced
internallygetFrameHeader_advanced
in decompress instead ofgetFrameContentSize
Testing done: