ninja: fix for generator_flags.output_dir
#25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put sanity back into `ninja`'s directory structures, many of them were confusing and the names differ through the file. Fix: #24
This was referenced Jul 15, 2016
|
Thank you! Tested and it works, with both normal |
springmeyer
pushed a commit
to Project-OSRM/node-osrm
that referenced
this pull request
Jul 18, 2016
- Avoids python dependency - Defaults to using ninja.js if ninja is not installed - refs indutny/gyp.js#25 - refs indutny/gyp.js#21 - refs #121 - refs mapbox/node-pre-gyp#205
|
Alright, landing! |
|
Landed in c617f5e, and released in 1.4.11 |
|
Thank you for testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put sanity back into
ninja's directory structures, many of them wereconfusing and the names differ through the file.
Fix: #24
cc @pmed @springmeyer