Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache mapped functions #531

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

majosm
Copy link
Collaborator

@majosm majosm commented Jul 26, 2024

Caches the results of mapping FunctionDefinitions. Caching is done globally to avoid re-traversing functions in different call stack frames.

Depends on #503 (merged) and #530 (merged).

@majosm majosm force-pushed the cache-mapped-function-results branch from 0ed120a to 0c73b20 Compare July 26, 2024 04:54
@majosm majosm mentioned this pull request Jul 26, 2024
@majosm majosm force-pushed the cache-mapped-function-results branch 6 times, most recently from dd6d54f to 2ff245d Compare August 2, 2024 21:33
@majosm majosm marked this pull request as ready for review August 2, 2024 22:24
@majosm
Copy link
Collaborator Author

majosm commented Aug 2, 2024

@inducer Should be ready for a look. I think the mypy errors are unrelated, they're occurring on main too.

@majosm majosm requested a review from inducer August 2, 2024 22:26
@majosm majosm force-pushed the cache-mapped-function-results branch from 2ff245d to f8c2c68 Compare August 12, 2024 20:45
@inducer inducer force-pushed the cache-mapped-function-results branch from f8c2c68 to 58c8dbf Compare August 25, 2024 04:54
@majosm majosm force-pushed the cache-mapped-function-results branch 2 times, most recently from 4519ce2 to 913d3d1 Compare September 5, 2024 19:23
@majosm majosm force-pushed the cache-mapped-function-results branch 2 times, most recently from 312e8ff to 72ce101 Compare September 24, 2024 17:47
This was referenced Sep 24, 2024
@inducer
Copy link
Owner

inducer commented Nov 14, 2024

Uh-oh. The recent typing apocalypse has made a bit of a mess of this. I've started resolving conflicts, but I got bogged down in pytato.transform. Could you take a look? (Or, if you've lost patience with me, I can also try and finish.)

@majosm majosm force-pushed the cache-mapped-function-results branch 3 times, most recently from a325da2 to b8cbbc5 Compare December 20, 2024 02:33
@majosm majosm force-pushed the cache-mapped-function-results branch from b8cbbc5 to e57fe22 Compare December 20, 2024 02:36
@majosm
Copy link
Collaborator Author

majosm commented Dec 20, 2024

@inducer Should be ready for review again (mypy error looks unrelated?). In e57fe22 I added a few questions/comments about things I noticed while resolving conflicts. I'll remove them after you've had a chance to glance at them.

@inducer
Copy link
Owner

inducer commented Dec 20, 2024

#571 should address the mypy issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants