number_distributed_tags: non-set, non-sorted numbering #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasdiener
commented
Nov 9, 2023
matthiasdiener
force-pushed
the
deterministic-mpi_tag-v2
branch
from
65d0142 to
70cc8a4
Compare
matthiasdiener
force-pushed
the
deterministic-mpi_tag-v2
branch
from
70cc8a4 to
9527630
Compare
matthiasdiener
commented
Feb 5, 2024
|
|
||
| # For the next assertion, find_distributed_partition needs to be | ||
| # deterministic too (https://github.com/inducer/pytato/pull/465). | ||
| # assert next(iter(distp.parts[0].name_to_send_nodes.values()))[0].comm_tag == 4242 # noqa: E501 |
inducer
approved these changes
Feb 6, 2024
|
|
||
| # For the next assertion, find_distributed_partition needs to be | ||
| # deterministic too (https://github.com/inducer/pytato/pull/465). | ||
| # assert next(iter(distp.parts[0].name_to_send_nodes.values()))[0].comm_tag == 4242 # noqa: E501 |
There was a problem hiding this comment.
File an issue to remind us to reenable it?
|
Thx! |
nkoskelo
pushed a commit
to nkoskelo/pytato
that referenced
this pull request
Mar 5, 2024
* number_distributed_tags: non-set, non-sorted numbering * make the test a bit more difficult * improve test * add comments based on review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #462/#467
cc @MTCam
Please squash