-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds PKCE, profile info, makes "me" optional in the request #59
Conversation
Unrelated but just spotted: line 156 of the source file still mentions the following being done by the IndieAuth spec. But it was dropped per 4386cfe. <li>Specifies a mechanism for a token endpoint and authorization endpoint to communicate</li> Can we roll that fix into here, since this PR will be regenerating all the output files? |
Grammar error:
Should not have an "a" before "either". |
In 6.2: - <p>The token endpoint verifies the access token using (how this verification is done is up to the implementation), and returns information about the token:</p>
+ <p>The token endpoint verifies the used access token (how this verification is done is up to the implementation), and returns information about the token:</p> |
The change in commit 227913b should probably be copied to apply to 5.3.3 as well, as that section contains the same sort of paragraph (starting with "The resulting profile URL MAY be different from what the user initially entered"). |
copy text from 227913b into the other section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last commit addresses all my comments. I have spotted nothing else, so this looks good to me 🚀
This PR addresses the issues in #41, #31, #39, and #19.
This PR also updates the compiled spec and archived versions.