Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix strict with babel runtime #3

Merged
merged 2 commits into from
May 15, 2020

Conversation

ntarocco
Copy link
Contributor

@ntarocco ntarocco requested a review from ThiefMaster May 14, 2020 17:41
@ThiefMaster
Copy link
Member

LGTM, what about adding a CHANGELOG file now that we'll make a second release?

@ntarocco
Copy link
Contributor Author

Added a second commit with the changelog and the release.

@ThiefMaster
Copy link
Member

(!) Mixing named and default exports
https://rollupjs.org/guide/en/#output-exports
The following entry modules are using named and default exports together:
src/index.js

Consumers of your bundle will have to use chunk['default'] to access their default export, which > may not be what you want. Use output.exports: 'named' to disable this warning

Is this warning expected?

@ntarocco
Copy link
Contributor Author

ntarocco commented May 15, 2020

(!) Mixing named and default exports
https://rollupjs.org/guide/en/#output-exports
The following entry modules are using named and default exports together:
src/index.js
Consumers of your bundle will have to use chunk['default'] to access their default export, which > may not be what you want. Use output.exports: 'named' to disable this warning

Is this warning expected?

Thanks for spotting it, I didn't notice it in the output... it looks like that auto is not so smart in the end... :| Reverted it back to how was it before.

I also changed the release date in the changelog to today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove strict mode for CommonJS build
2 participants