You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The List component variant property allows for 3 settings 'ordered', 'unordered' or 'plain' with 'unordered' being the default and only 1 value accepted. However this controls 2 different changes in the component. Unordered and Ordered dictate the element of the container 'ul' vs 'ol' with 'ul' as default. Plain simply adds an additional className value of 'rvt-list-plain'. Possible combinations:
ul with no class added (variant='unordered')
ul with rvt-list-plain added (variant='plain')
ol with no class added (variant='ordered')
ol with rvt-list-plain added (Not Possible)
Current work around would be ordered variant with className manually set but is not user friendly and with description list already split out the value of using the component is already minimal.
The text was updated successfully, but these errors were encountered:
This issue should also include consideration of the rvt-list-inline class.
What if these are the values (and the result) for the variant prop?
description (dl.rvt-list-description)
ordered (ol.rvt-list)
ordered-inline (ol.rvt-list-inline)
ordered-plain (ol.rvt-list-plain)
unordered (ul.rvt-list)
unordered-inline (ul.rvt-list-inline)
unordered-plain (ul.rvt-list-plain)
Also, I see a rvt-list-reset class. I've never used it. It is not documented, so maybe we shouldn't support it. But if we would add it, maybe we'd need these, too?
ordered-reset (ol.rvt-list-reset)
unordered-reset (ul.rvt-list-reset)
I could see later contributing a new key/value variant for description lists (whatever it would be called). So, that could be added like:
The List component variant property allows for 3 settings 'ordered', 'unordered' or 'plain' with 'unordered' being the default and only 1 value accepted. However this controls 2 different changes in the component. Unordered and Ordered dictate the element of the container 'ul' vs 'ol' with 'ul' as default. Plain simply adds an additional className value of 'rvt-list-plain'. Possible combinations:
Current work around would be ordered variant with className manually set but is not user friendly and with description list already split out the value of using the component is already minimal.
The text was updated successfully, but these errors were encountered: