Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IWF-542: Update iwf-idl and replace deprecated workflow type error #538

Merged
merged 2 commits into from
Feb 4, 2025
Merged

IWF-542: Update iwf-idl and replace deprecated workflow type error #538

merged 2 commits into from
Feb 4, 2025

Conversation

stevo89519
Copy link
Contributor

Description

Checklist

  • Code compiles correctly
  • Tests for the changes have been added
  • All tests passing
  • This PR change is backwards-compatible
  • This PR CONTAINS a (planned) breaking change (it is not backwards compatible)

Related Issue

Closes #issue_number

@codecov Codecov
Copy link

codecov bot commented Jan 31, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.59%. Comparing base (2a439d5) to head (858d526).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
service/interpreter/activityImpl.go 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #538   +/-   ##
=======================================
  Coverage   64.59%   64.59%           
=======================================
  Files          59       59           
  Lines        6617     6617           
=======================================
  Hits         4274     4274           
  Misses       2064     2064           
  Partials      279      279

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevo89519 stevo89519 force-pushed the jira/sharrison/IWF-542 branch from d945d1a to 23dc72b Compare January 31, 2025 18:51
lwolczynski
lwolczynski approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@lwolczynski lwolczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a breaking change, so maybe we should hold off with merging to NOT release this Monday and wait till the SDK changes are ready to be merged?

@stevo89519
Copy link
Contributor Author

This will be a breaking change, so maybe we should hold off with merging to NOT release this Monday and wait till the SDK changes are ready to be merged?

Yes that's my plan. Never merge on Fridays lol. Working on getting the sdk MRs out now.

@stevo89519 stevo89519 merged commit 91788a0 into main Feb 4, 2025
10 checks passed
@stevo89519 stevo89519 deleted the jira/sharrison/IWF-542 branch February 4, 2025 18:28
@lwolczynski lwolczynski linked an issue Feb 5, 2025 that may be closed by this pull request
Rename STATE_API_FAIL_MAX_OUT_RETRY_ERROR_TYPE to be less confusing #526
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwolczynski lwolczynski lwolczynski approved these changes

@samuel27m samuel27m Awaiting requested review from samuel27m

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename STATE_API_FAIL_MAX_OUT_RETRY_ERROR_TYPE to be less confusing
2 participants
@stevo89519 @lwolczynski