IWF-542: Update iwf-idl and replace deprecated workflow type error

indeedeng · Jan 31, 2025 · 23dc72b · 23dc72b
1 parent 2a439d5
commit 23dc72b
Show file tree

Hide file tree

Showing 10 changed files with 82 additions and 9 deletions.
diff --git a/gen/iwfidl/api/openapi.yaml b/gen/iwfidl/api/openapi.yaml
@@ -738,6 +738,7 @@ components:
         workflowConfigOverride:
           disableSystemSearchAttribute: true
           continueAsNewThreshold: 1
+          optimizeTimer: true
           continueAsNewPageSizeInBytes: 4
           executingStateIdMode: null
           optimizeActivity: true
@@ -1011,6 +1012,7 @@ components:
           workflowConfigOverride:
             disableSystemSearchAttribute: true
             continueAsNewThreshold: 1
+            optimizeTimer: true
             continueAsNewPageSizeInBytes: 4
             executingStateIdMode: null
             optimizeActivity: true
@@ -1341,6 +1343,7 @@ components:
       - STATE_DECISION_FAILING_WORKFLOW_ERROR_TYPE
       - CLIENT_API_FAILING_WORKFLOW_ERROR_TYPE
       - STATE_API_FAIL_MAX_OUT_RETRY_ERROR_TYPE
+      - STATE_API_FAIL_ERROR_TYPE
       - INVALID_USER_WORKFLOW_CODE_ERROR_TYPE
       - RPC_ACQUIRE_LOCK_FAILURE
       - SERVER_INTERNAL_ERROR_TYPE
@@ -1601,6 +1604,7 @@ components:
         workflowConfig:
           disableSystemSearchAttribute: true
           continueAsNewThreshold: 1
+          optimizeTimer: true
           continueAsNewPageSizeInBytes: 4
           executingStateIdMode: null
           optimizeActivity: true
@@ -3284,6 +3288,7 @@ components:
       example:
         disableSystemSearchAttribute: true
         continueAsNewThreshold: 1
+        optimizeTimer: true
         continueAsNewPageSizeInBytes: 4
         executingStateIdMode: null
         optimizeActivity: true
@@ -3298,6 +3303,8 @@ components:
           type: integer
         optimizeActivity:
           type: boolean
+        optimizeTimer:
+          type: boolean
       type: object
     Context:
       example:

diff --git a/gen/iwfidl/docs/WorkflowConfig.md b/gen/iwfidl/docs/WorkflowConfig.md
@@ -9,6 +9,7 @@ Name | Type | Description | Notes
 **ContinueAsNewThreshold** | Pointer to **int32** |  | [optional] 
 **ContinueAsNewPageSizeInBytes** | Pointer to **int32** |  | [optional] 
 **OptimizeActivity** | Pointer to **bool** |  | [optional] 
+**OptimizeTimer** | Pointer to **bool** |  | [optional] 
 
 ## Methods
 
@@ -154,6 +155,31 @@ SetOptimizeActivity sets OptimizeActivity field to given value.
 
 HasOptimizeActivity returns a boolean if a field has been set.
 
+### GetOptimizeTimer
+
+`func (o *WorkflowConfig) GetOptimizeTimer() bool`
+
+GetOptimizeTimer returns the OptimizeTimer field if non-nil, zero value otherwise.
+
+### GetOptimizeTimerOk
+
+`func (o *WorkflowConfig) GetOptimizeTimerOk() (*bool, bool)`
+
+GetOptimizeTimerOk returns a tuple with the OptimizeTimer field if it's non-nil, zero value otherwise
+and a boolean to check if the value has been set.
+
+### SetOptimizeTimer
+
+`func (o *WorkflowConfig) SetOptimizeTimer(v bool)`
+
+SetOptimizeTimer sets OptimizeTimer field to given value.
+
+### HasOptimizeTimer
+
+`func (o *WorkflowConfig) HasOptimizeTimer() bool`
+
+HasOptimizeTimer returns a boolean if a field has been set.
+
 
 [[Back to Model list]](../README.md#documentation-for-models) [[Back to API list]](../README.md#documentation-for-api-endpoints) [[Back to README]](../README.md)
 

diff --git a/gen/iwfidl/docs/WorkflowErrorType.md b/gen/iwfidl/docs/WorkflowErrorType.md
@@ -9,6 +9,8 @@
 
 * `STATE_API_FAIL_MAX_OUT_RETRY_ERROR_TYPE` (value: `"STATE_API_FAIL_MAX_OUT_RETRY_ERROR_TYPE"`)
 
+* `STATE_API_FAIL_ERROR_TYPE` (value: `"STATE_API_FAIL_ERROR_TYPE"`)
+
 * `INVALID_USER_WORKFLOW_CODE_ERROR_TYPE` (value: `"INVALID_USER_WORKFLOW_CODE_ERROR_TYPE"`)
 
 * `RPC_ACQUIRE_LOCK_FAILURE` (value: `"RPC_ACQUIRE_LOCK_FAILURE"`)

diff --git a/gen/iwfidl/model_workflow_config.go b/gen/iwfidl/model_workflow_config.go
diff --git a/gen/iwfidl/model_workflow_error_type.go b/gen/iwfidl/model_workflow_error_type.go
diff --git a/integ/wf_state_api_fail_test.go b/integ/wf_state_api_fail_test.go
@@ -95,7 +95,7 @@ func doTestStateApiFail(t *testing.T, backendType service.BackendType, config *i
 	assertions.Equalf(&iwfidl.WorkflowGetResponse{
 		WorkflowRunId:  startResp.GetWorkflowRunId(),
 		WorkflowStatus: iwfidl.FAILED,
-		ErrorType:      ptr.Any(iwfidl.STATE_API_FAIL_MAX_OUT_RETRY_ERROR_TYPE),
+		ErrorType:      ptr.Any(iwfidl.STATE_API_FAIL_ERROR_TYPE),
 		ErrorMessage:   iwfidl.PtrString("statusCode: 400, responseBody: {}, errMsg: 400 Bad Request  (%!s(*string=<nil>))"),
 	}, resp, "response not expected")
 }
diff --git a/integ/wf_state_api_timeout_test.go b/integ/wf_state_api_timeout_test.go
@@ -91,7 +91,7 @@ func doTestStateApiTimeout(t *testing.T, backendType service.BackendType, config
 	assertions.Equalf(&iwfidl.WorkflowGetResponse{
 		WorkflowRunId:  startResp.GetWorkflowRunId(),
 		WorkflowStatus: iwfidl.FAILED,
-		ErrorType:      ptr.Any(iwfidl.STATE_API_FAIL_MAX_OUT_RETRY_ERROR_TYPE),
+		ErrorType:      ptr.Any(iwfidl.STATE_API_FAIL_ERROR_TYPE),
 		ErrorMessage:   resp.ErrorMessage,
 	}, resp, "response not expected")
 }
diff --git a/replayTests/history/v4-local-activity-optimization.json b/replayTests/history/v4-local-activity-optimization.json
@@ -367,7 +367,7 @@
           "encodedAttributes": null,
           "cause": null,
           "applicationFailureInfo": {
-            "type": "STATE_API_FAIL_MAX_OUT_RETRY_ERROR_TYPE",
+            "type": "STATE_API_FAIL_ERROR_TYPE",
             "nonRetryable": false,
             "details": {
               "payloads": [
@@ -468,7 +468,7 @@
             "encodedAttributes": null,
             "cause": null,
             "applicationFailureInfo": {
-              "type": "STATE_API_FAIL_MAX_OUT_RETRY_ERROR_TYPE",
+              "type": "STATE_API_FAIL_ERROR_TYPE",
               "nonRetryable": false,
               "details": {
                 "payloads": [

diff --git a/service/interpreter/activityImpl.go b/service/interpreter/activityImpl.go
@@ -65,7 +65,7 @@ func StateApiWaitUntil(
 		})
 		return nil, composeHttpError(
 			activityInfo.IsLocalActivity,
-			provider, err, httpResp, string(iwfidl.STATE_API_FAIL_MAX_OUT_RETRY_ERROR_TYPE))
+			provider, err, httpResp, string(iwfidl.STATE_API_FAIL_ERROR_TYPE))
 	}
 
 	if err := checkCommandRequestFromWaitUntilResponse(resp); err != nil {
@@ -150,7 +150,7 @@ func StateApiExecute(
 		})
 		return nil, composeHttpError(
 			activityInfo.IsLocalActivity,
-			provider, err, httpResp, string(iwfidl.STATE_API_FAIL_MAX_OUT_RETRY_ERROR_TYPE))
+			provider, err, httpResp, string(iwfidl.STATE_API_FAIL_ERROR_TYPE))
 	}
 
 	if err = checkStateDecisionFromResponse(resp); err != nil {
@@ -206,13 +206,13 @@ func printDebugMsg(logger UnifiedLogger, err error, url string) {
 
 func composeStartApiRespError(provider ActivityProvider, err error, resp *iwfidl.WorkflowStateStartResponse) error {
 	respStr, _ := resp.MarshalJSON()
-	return provider.NewApplicationError(string(iwfidl.STATE_API_FAIL_MAX_OUT_RETRY_ERROR_TYPE),
+	return provider.NewApplicationError(string(iwfidl.STATE_API_FAIL_ERROR_TYPE),
 		fmt.Sprintf("err msg: %v, response: %v", err, string(respStr)))
 }
 
 func composeExecuteApiRespError(provider ActivityProvider, err error, resp *iwfidl.WorkflowStateDecideResponse) error {
 	respStr, _ := resp.MarshalJSON()
-	return provider.NewApplicationError(string(iwfidl.STATE_API_FAIL_MAX_OUT_RETRY_ERROR_TYPE),
+	return provider.NewApplicationError(string(iwfidl.STATE_API_FAIL_ERROR_TYPE),
 		fmt.Sprintf("err msg: %v, response: %v", err, string(respStr)))
 }
 

diff --git a/service/interpreter/workflowImpl.go b/service/interpreter/workflowImpl.go
@@ -990,7 +990,7 @@ func convertStateApiActivityError(provider WorkflowProvider, err error) error {
 	if provider.IsApplicationError(err) {
 		return err
 	}
-	return provider.NewApplicationError(string(iwfidl.STATE_API_FAIL_MAX_OUT_RETRY_ERROR_TYPE), err.Error())
+	return provider.NewApplicationError(string(iwfidl.STATE_API_FAIL_ERROR_TYPE), err.Error())
 }
 
 func getCommandThreadName(prefix string, stateExecId, cmdId string, idx int) string {