IWF-397: Add channel sizes data #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwolczynski
force-pushed
the
jira/lwolczynski/IWF-397
branch
from
722414d to
23f36f2
Compare
longquanzheng
approved these changes
Dec 9, 2024
| return server_channel_size + buffer_channel_size | ||
|
|
||
| def get_signal_channel_size(self, channel_name): | ||
| if ( |
There was a problem hiding this comment.
I think we also need to check the signal type
There was a problem hiding this comment.
Do you mean checking if the signal channel exists?
Communication object currently only stores internal channels in the type_store. I will need to extend it with _signal_type_store to do it
There was a problem hiding this comment.
Yes. Oh that’s right because communication never needed to access that
samuel27m
approved these changes
Dec 10, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.