IWF-157: Fix typo IdReusePolicy of ALLOW_IF_PREVIOUS_EXISTS_ABNORMALLY #33
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
I guess we need to upgrade this to use official action: https://github.com/marketplace/actions/install-poetry-action This is no longer working properly with old nodeJs: knowsuchagency/poetry-install#4 |
This comment was marked as resolved.
This comment was marked as resolved.
.github/workflows/tests.yml
Outdated
| env: | ||
| POETRY_VIRTUALENVS_CREATE: false | ||
| with: | ||
| virtualenvs-create: false |
There was a problem hiding this comment.
I copied this value from somewhere else but didn't fully understand. do you know why this has to be 'false'?
There was a problem hiding this comment.
No I don't know. I'm also not sure if calling 'poetry install' here will cause any downsides? It fixed the workflow issues.
| @@ -291,7 +291,7 @@ def default(self, o: Any) -> Any: | |||
| See :py:meth:`json.JSONEncoder.default`. | |||
| """ | |||
| # Dataclass support | |||
| if dataclasses.is_dataclass(o): | |||
| if dataclasses.is_dataclass(o) and not isinstance(o, type): | |||
There was a problem hiding this comment.
Fixes mypy error:
No overload variant of "asdict" matches argument type "Type[DataclassInstance]" [call-overload]
There was a problem hiding this comment.
I didn't see this error before.
Did you find this fix somewhere? can you put a reference here for more context?
There was a problem hiding this comment.
Found the fix here: python/mypy#17550 (comment)
No description provided.