Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge sometimes not working when switching between documents in integrated curation mode #5278

Closed
reckart opened this issue Feb 6, 2025 · 0 comments
Closed

Merge sometimes not working when switching between documents in integrated curation mode #5278

reckart opened this issue Feb 6, 2025 · 0 comments
Assignees
@reckart
Labels
🐛 Bug Something isn't working Module: Curation
Milestone
35.3

Comments

@reckart
Copy link
Member

reckart commented Feb 6, 2025

Describe the bug
When using the integrated curation mode, switching from one document to the next sometimes does not work properly.

To Reproduce
Steps to reproduce the behavior:

  1. Have two documents in your project
  2. Ensure that the 1. document has only been opened and annotated by user 1
  3. Ensure that the 2. document has only been opened and annotated by user 2
  4. Make sure both documents as finished
  5. As a curator, open document 1 using the integrated curation mode
  6. Use the action bar to switch to document 2

Expected behavior
The annotations of user 2 should have been auto-merged on document 2 just as the annotations of user 1 have been on document 1.

Please complete the following information:

  • Version and build ID: 35.2
@reckart reckart added the 🐛 Bug Something isn't working label Feb 6, 2025
@reckart reckart added this to the 35.3 milestone Feb 6, 2025
@reckart reckart self-assigned this Feb 6, 2025
@reckart reckart added this to Kanban Feb 6, 2025
@github-project-automation github-project-automation bot moved this to 🔖 To do in Kanban Feb 6, 2025
reckart added a commit that referenced this issue Feb 6, 2025
@reckart
#5278 - Merge sometimes not working when switching between documents …
ea85827 
…in integrated curation mode

- Assign the proper source users for the new document before triggering the auto-merge in onPreparingToOpenDocumentEvent
- Remove assignment of source users later onDocumentOpened
reckart added a commit that referenced this issue Feb 6, 2025
@reckart
Merge pull request #5279 from inception-project/bugfix/5278-Merge-som…
7207b81 
…etimes-not-working-when-switching-between-documents-in-integrated-curation-mode

#5278 - Merge sometimes not working when switching between documents in integrated curation mode
@reckart reckart closed this as completed Feb 6, 2025
@github-project-automation github-project-automation bot moved this from 🔖 To do to 🍹 Done in Kanban Feb 6, 2025
reckart added a commit that referenced this issue Feb 9, 2025
@reckart
Merge branch 'release/35.x'
9c56789 
* release/35.x:
  #5269 - Non-break space character in PDF causing load problem with text Brat sentence view
  #5278 - Merge sometimes not working when switching between documents in integrated curation mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
🐛 Bug Something isn't working Module: Curation
Projects
Kanban
Status: 🍹 Done
Milestone
35.3
Development

No branches or pull requests
1 participant
@reckart