-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate_watersurfaces_hab: update to v2020 #54
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work @cecileherr 🎉! You pay attention to various relevant aspects, which is much appreciated.
Interesting to see how you fixed geometries. It seems worth doing that for other habitatmap-derived data sources (see specific comment).
It seems best to update the document title to 'Generating watersurfaces_hab', for consistency with other ones.
I believe the specific comments are just aesthetic or informative and will not affect the actual result (if re-run, the checksum should still be the same).
I checked the xxhsums of the input files, they're fine.
Thanks for attaching the html and data source file (file to be overwritten on the Q-drive as well, where we just save the latest versions).
src/generate_watersurfaces_hab/10_generate_watersurfaces_hab.Rmd
Outdated
Show resolved
Hide resolved
"Error in CPL_geos_op2(op, x, y) : | ||
Evaluation error: TopologyException: Input geom 1 is invalid: Ring Self-intersection at or near point 78082.684000000358 228483.7210999988 at 78082.684000000358 228483.7210999988.". | ||
|
||
We solve the problem based on this [article: Tidying feature geometries with sf](https://www.r-spatial.org/r/2017/03/19/invalid.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
src/generate_watersurfaces_hab/10_generate_watersurfaces_hab.Rmd
Outdated
Show resolved
Hide resolved
Indeed, I re-ran the script and the checksum stay the same.
@florisvdh: shall I put the file on the Q-drive or do you prefer to do it yourself? |
I updated the script to implement your suggestions. Here is the new version of the rendered notebook (quite big due to the maps): |
You're welcome to do so @cecileherr - thanks. I'll have a look at your update tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @cecileherr, thanks. The maps are an attractive approach to explore differences.
You can leave this PR open, just like PR #50, until dependent work in n2khab
is finished. So you can add further stuff here as needed.
Main changes:
Here is the rendered notebook:
generating_watersurfaces_hab_rendered_nb.zip
And the new version of watersurfaces_hab:
watersurfaces_hab_2020_gpkg.zip