Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bounding box queries can use private coordinates #68 #419

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pleary
Copy link
Member

@pleary pleary commented Jan 3, 2024

@pleary pleary requested a review from kueda January 3, 2024 17:58
Copy link
Member

@kueda kueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and addresses the issue raised in #68, so I don't think there are any blocking problems. That said, I would like to see some integration tests showing that this is working, something along the lines of

describe( "filtering by bounding box", ( ) => {
  describe( "including an obscured observation's true coordinates but not the obscured coordinates", ( ) => {
    it( "should return the observation when viewed by the observer" );
    it( "should return the observation when viewed someone the observer trusts" );
    it( "should not return the observation when viewed by someone the observer doesn't trust" );
  } );
  describe( "including an obscured observation's obscured coordinates but not the true coordinates", ( ) => {
    it( "should not return the observation when viewed by the observer" );
    it( "should not return the observation when viewed someone the observer trusts" );
    it( "should return the observation when viewed by someone the observer doesn't trust" );
  } );
} );

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bounding box queries don't use private coordinates, even for obs you have permission to see
2 participants