-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update NetInfo dependency #343
base: master
Are you sure you want to change the base?
Conversation
Please merge this PR. |
Same issue goes for AsyncStorage as well, I think a few other packages too |
Anything else that can be done for this? Getting the error |
My workaround now is to clone this entire repo, then add the directory as an Npm dependency.
https://github.com/pkcwong/react-native-meteor-starter/blob/master/package.json#L13 You can then fix the dependencies yourself. |
Plz merge this fix ! |
@ma-lemire Last commit to this repo is nearly a year ago. You can use this workaround for now. |
@pkcwong Thx man works well ! i just add async-storage with @react-native-community/async-storage |
@charpeni could you merge this pls? |
downgrading react-native to 0.59.10 works as an alternative to #343 (comment) |
My team ran into this issue and was able to fix it using the commit in this PR. This is a definitive issue with using React Native versions 0.60.0 and above. @charpeni please merge this PR into the repo |
Fix for #342
Changed NetInfo dependency from
react-native
to@react-native-community
as suggested in React Native docs.https://facebook.github.io/react-native/docs/netinfo.html