Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetInfo change event changed to connectionChange event. #273

Merged
merged 1 commit into from
Oct 24, 2017

Conversation

ujwal-setlur
Copy link
Contributor

Resolves #272

@rijk rijk mentioned this pull request Oct 3, 2017
@mgscreativa
Copy link

Maybe you can check which RN version is currently installed so you can choose the NetInfo change event name, for backward compatibility.

Maybe something like
const rnVersion = require('react-native/package.json').version

@ujwal-setlur
Copy link
Contributor Author

good point. will add.

@charpeni charpeni self-assigned this Oct 24, 2017
@charpeni
Copy link
Collaborator

Thank you for your contribution @ujwal-setlur.

@charpeni charpeni merged commit dea57bc into inProgress-team:master Oct 24, 2017
@mgscreativa
Copy link

mgscreativa commented Oct 24, 2017

WARNING! this change break backward compatibility with old RN versions... please check #273 (comment)

@elie222
Copy link

elie222 commented Oct 28, 2017

We have an issue where now every time a user switches apps and back into our app, the login screen flashes up for a second and then they lose the place they were at in the app. I have a feeling it has to do with this update. Any ideas?

@ujwal-setlur
Copy link
Contributor Author

This update should not have anything to do with what you are seeing. This was happening even before, at least for me. When app goes into background, I believe network connection to the server is lost. When the app comes back into focus, connectivity to meteor server is re-established. Depending on how your code is set up, when connection to meteor is restored, the login session is not quite set restored yet. During that time, login screen is shown. Then login session is restored, and the user is logged back in. Where the user ends up depends on your code. If you don't maintain any state in your app, your user will end up on the default screen after logging. At least that's how my app behaves. I have been meaning to add state management to the app, but haven't done it yet.

@elie222
Copy link

elie222 commented Oct 28, 2017

No it was definitely an update to the repo that broke it for us. It breaks in 1.0.6 for us. So I assume it's this:
1.0.6...master#diff-53dfeae4c43fde5283e3ca4afff51297R100

Works fine in 1.0.5 for us

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants