Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed deprecated React.createClass() to a new module createReactClass() #270

Merged
merged 4 commits into from
Oct 24, 2017

Conversation

rj-david
Copy link
Contributor

@rj-david rj-david commented Sep 6, 2017

React has deprecated React.createClass() function but they separated it to a new module create-react-class for those using mixins. Just changed the function call from the deprecated function to the new module

@xerotolerant
Copy link

I think this needs to be merged now, createContainer outright fails with react native 0.48.4.

@jon617
Copy link

jon617 commented Oct 2, 2017

Please commit this so my react-native-meteor will work!

I'm getting an error: "createClass is not a function" when using react-native-meteor with the 1.1.0 (latest) release of react-native-meteor. The problem should be fixed from the commit referenced above, which changes React.createClass() to newly created createReactClass().

@tquiroga
Copy link

I just took a course on React Native and can't practice as this PR needs to be merged. Not cool

@xerotolerant
Copy link

xerotolerant commented Oct 13, 2017 via email

@jon617
Copy link

jon617 commented Oct 13, 2017

I applied the fix in my fork, you're welcome to use mine, although I recommended you fork the fix yourself and use your own.

In package.json, under the dependencies section:
"react-native-meteor": "https://github.com/jon617/react-native-meteor/tarball/master",

paulo2nd added a commit to paulo2nd/react-native-meteor that referenced this pull request Oct 19, 2017
@charpeni charpeni self-assigned this Oct 24, 2017
@charpeni charpeni merged commit 3ad1e43 into inProgress-team:master Oct 24, 2017
@charpeni
Copy link
Collaborator

Sorry for the delay.

We'll shortly release a version for the latest version of React Native & React.

@rj-david
Copy link
Contributor Author

@charpeni, createContainer was deprecated by the meteor team last week. Just, FYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants