-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed deprecated React.createClass() to a new module createReactClass() #270
Conversation
I think this needs to be merged now, createContainer outright fails with react native 0.48.4. |
Please commit this so my react-native-meteor will work! I'm getting an error: "createClass is not a function" when using react-native-meteor with the 1.1.0 (latest) release of react-native-meteor. The problem should be fixed from the commit referenced above, which changes React.createClass() to newly created createReactClass(). |
I just took a course on React Native and can't practice as this PR needs to be merged. Not cool |
Guys the inProgress team is probably busy or moved on to another framework.
Just make a branch of your own and do the merge.
https://stackoverflow.com/questions/10386310/how-to-install-a-private-npm-module-without-my-own-registry
You can follow this to do it. The beauty of open source is that you don't
have to wait for anybody to do anything.
…On Fri, 13 Oct 2017 at 11:30 AM Thomas Quiroga ***@***.***> wrote:
I just took a course on React Native and can't practice as this PR needs
to be merged. Not cool
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#270 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AQaDGHb6MnPOExZyK_x-Xc3piMMexv7xks5sr4IsgaJpZM4POcyd>
.
|
I applied the fix in my fork, you're welcome to use mine, although I recommended you fork the fix yourself and use your own. In package.json, under the dependencies section: |
Sorry for the delay. We'll shortly release a version for the latest version of React Native & React. |
@charpeni, createContainer was deprecated by the meteor team last week. Just, FYI. |
React has deprecated React.createClass() function but they separated it to a new module create-react-class for those using mixins. Just changed the function call from the deprecated function to the new module