Issue to update #183

txs · 2016-12-27T18:14:27Z

I'm having a issue about this.db.batchedUpdates is not a function inside WriteTransaction.js
And also _.all is not a function

Please help

spencercarli · 2016-12-27T18:51:59Z

Possibly related:

I believe the issues comes from this line:

react-native-meteor/src/Data.js

Line 9 in 874112d

db.batchedUpdates = ReactNative.unstable_batchedUpdates;

RN source where it was defined: https://github.com/facebook/react-native/blob/3683beb88ab3233038ac32b9c33112d537478088/Libraries/Renderer/src/renderers/native/ReactNative.js#L41

@txs what version of React Native are you using? I wonder if ReactNative.unstable_batchedUpdates is no longer valid.

@Mokto I checked out the git blame and looks like you made that change - any insight on this?

txs · 2016-12-28T08:18:37Z

RN 0.39.2

txs · 2016-12-28T08:19:54Z

I'm using the ws not wss

txs · 2016-12-28T08:21:06Z

the line is in WriteTransaction.js "return this.db.batchedUpdates((function(_this) {" line 75

txs · 2017-01-28T02:23:00Z

@spencercarli Do you know how to solve it?

spencercarli · 2017-01-29T20:13:09Z

@txs no sorry I don't. I'm using the latest React Native and latest version of this packages without any issues.

txs · 2017-04-18T18:43:34Z

I still have this issue and the batchupdate seems deprecated

turbobuilt · 2017-05-11T19:05:20Z

I'm having this issue in .45.0-rc.0. When I downrgrade to .44 it goes away

txs · 2017-05-13T19:48:54Z

I think it's a issue with minimongo 0.48

txs · 2017-05-13T19:54:31Z

I'm using react native 0.42, I'll try upgrade to 0.44

txs · 2017-05-13T20:20:15Z

I think we have to change it to unstable_batchedUpdate

txs · 2017-05-15T06:33:45Z

Can require("reactUpdates") solve the issue? dtruel <[email protected]> 於 2017年5月12日週五上午3:05寫道：

…

I'm having this issue in .45.0-rc.0. When I downrgrade to .44 it goes away — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#183 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAh1WW-SlRY7zD-3VIpOdXUyzS6EwBPwks5r41vxgaJpZM4LWbak> .

turbobuilt · 2017-05-15T17:40:27Z

Hey @txs, I don't have a lot of extra time right now so I'm going to wait to test till .45 comes out of rc because it makes upgrading quicker. Thanks for the tip though.

anhtuank7c · 2017-06-08T04:10:29Z

0.45.0 is now official and still got this error :(

txs · 2017-06-08T07:59:16Z

Are you using the react native or react native web? Nguyễn Anh Tuấn <[email protected]> 於 2017年6月8日週四下午12:10寫道：

…

0.45.0 is now official and still got this error :( — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#183 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAh1WYFYYvYR36ISBY8ddmQjdrnJKPGFks5sB3Q3gaJpZM4LWbak> .

anhtuank7c · 2017-06-08T08:14:27Z

@txs I use React Native.

	"dependencies": {
		"react": "16.0.0-alpha.12",
		"react-native": "0.45.0"
        }

steven-tib · 2017-06-09T00:10:08Z

I'm having the same issue,
I just tried to update to 0.45 and also have react 16 alpha dependency
Anyone found a way to fix it with 0.45 or should I downgrade to 0.44?

anhtuank7c · 2017-06-09T01:33:27Z

@steven-tib
I have to use RN 44 instead of 45.

steven-tib · 2017-06-09T07:59:29Z

@anhtuank7c thanks, I'll switch back to 0.44 then

Nauzer · 2017-06-09T13:14:41Z

I'm having the same issue. Downgrading to 0.44 has helped.
Is this an issue of React-Native or with this package?

Edit issue in mini-mongo-cache package

wenzelmkay · 2017-06-12T20:10:53Z

I'm having the same problem, and I'm having trouble figuring out how to downgrade to 0.44. Could anyone point me in the direction of some instructions on how to downgrade?

Nauzer · 2017-06-12T20:48:54Z

I think you can just remove your node_modules folder, update the version in your package.json and run npm install.

Sent from my OnePlus ONEPLUS A3003 using FastHub

Nauzer · 2017-06-13T10:42:00Z

@steven-tib to avoid staying stuck on 0.44, I was looking into fixing this.
Haven't gotten a lot further though. How about you?

Nauzer · 2017-06-13T12:48:48Z

I was able to get it to work by using ReactDOM. Which is ofcourse not a real solution. Shouldn't need ReactDOM dependency in a react-native project. Anyway sharing it here to get people going until a more structural solution is found.

@txs @spencercarli @Mokto @dtruel Any ideas?

Data.js:

// line 
import ReactDOM from 'react-dom';
...
// line 9 change to:
db.batchedUpdates = ReactDOM.unstable_batchedUpdates;

Make sure to add ReactDOM to your project dependencies.

A working branch can be found here:
Nauzer@4c18bbe

EDIT: I opened an issue in the ReactNative repo as the error is caused by ReactNative no longer exposing unstable_batchedUpdates method.

steven-tib · 2017-06-13T15:58:28Z

@Nauzer I haven't checked this further sorry, just downgraded for now. Thanks for trying to fix it though

spencercarli · 2017-06-13T16:01:16Z

Been working on this all morning. Having trouble upgrading to 0.45 - my app crashes whenever I turn remote debugging on 🙄

Nauzer · 2017-06-13T17:57:22Z

@spencercarli same here.
All I could do was use ReactDOM to replace it as a hack... Let's hope someone at FB looks at the react-native issue I posted.

For your issue --> Had this same issue. Here's helped for me:

remove node_modules
npm install
clear build in xcodeproject/workspace (Shift + Cmd + K)
clear build folder in xcodeproject/workspace (Alt + Shift + Cmd + K)
react-native run-ios

Also upgrading to 0.45.1 made everything a lot better in terms of build stability. Doesn't solve the issue though.

@steven-tib Downgrade doesn't do for me because of some issue with react-native-maps. Let's see.

spencercarli · 2017-06-13T18:24:00Z

@Nauzer the issue I had (I think) was related to react-native-maps. I was on 0.43 then upgraded to 0.44, maps didn't work so I unlinked and relinked react-native-maps which fixed everything in 0.44, then went to 0.45. Now batchedUpdates 😄

react-dom crashes my app for some reason. Hopefully I can figure it out!

Nauzer · 2017-06-13T18:48:28Z

What kind of error are you getting? I included [email protected] as a dependency of my react-native-meteor fork not directly in my project.

BTW, what your experience on RN. Is it always such a pain in the ... or is it just a unlucky moment for me to step in? ;-)

Sent from my OnePlus ONEPLUS A3003 using FastHub

spencercarli · 2017-06-13T23:10:25Z

@Nauzer I was (stupidly) using the wrong version of react-dom - completely neglected to see your working branch the branch you linked to! Thanks for providing that!

You just stepped in at a lucky time 😄 - this issue just started hitting most people (except OP) in the last few days with the release of RN v0.45 (my email has been inundated with questions about it)

Other than that there haven't been many issues (at least from my experience)

edmundkwok · 2017-06-14T05:00:32Z

Looks like 'ReactNativeInternals' (which exported unstable_batchedUpdates) was removed from being exposed as per:

facebook/react-native@f3dbddc#diff-834d77988fd4294e13e3e35533b3e248L161

While waiting for an update on facebook/react-native#14490, I did the following change in react-native-meteor to import ReactNativeInternals directly:

Data.js

// Line 1
- import ReactNative from 'react-native';
+ const ReactNative = require('react-native/Libraries/Renderer/src/renderers/native/ReactNative');

Seems like it's working, but may not be the best long term fix.

What do you guys think?

Nauzer · 2017-06-14T06:31:06Z

Thanks @edmundkwok I was on this trail yesterday by using ReactNativeStack/ReactNativeFiber - didn't get it to work. Good job!
One thing - I would suggest sticking to ES6 imports.

Data.js:

// line 1
- import ReactNative from 'react-native';
+import ReactNative from 'react-native/Libraries/Renderer/src/renderers/native/ReactNative'

Maybe you want to post your solution to the RN Issue to add some context?

edmundkwok · 2017-06-14T09:44:47Z

Thanks @Nauzer! Yes, of course, we should stick to ES6 😉

I have added a comment on facebook/react-native#14490

wenzelmkay · 2017-06-15T19:18:06Z

@Nauzer Thanks for your previous help! I have a question that might be kind of dumb, but where should I be adding the change recommended by @edmundkwok to? (I'm very new to coding + react-native in general).

Nauzer · 2017-06-15T21:32:02Z

Hi @wenzelmk
Until we merge this in this repo somehow (for that we need to confirm the issue in the react-native repo link to above) you can use my branch.

git clone https://github.com/Nauzer/react-native-meteor.git
in a directory of your liking.

In your project's package.json replace react-native-meteor with the relative path to the directory where you cloned it. I did it in my project's parent folder.

-"react-native-meteor": "^1.0.3",
+"react-native-meteor": "../react-native-meteor"

remove the node_modules folder

npm install

And you should be good to go :)

abser · 2017-06-16T08:08:08Z

Thanks @Nauzer .
It helps me as well.

ujwal-setlur · 2017-06-20T00:28:12Z

Just ran into this as well. Downgrading to 0.44. Hopefully, I won't run into any issues on that path.

ujwal-setlur · 2017-06-20T00:35:09Z

OK, downgrading to RN 0.44 worked for me. Hopefully, this will get resolved soon.

…ress-team#183.

Nauzer · 2017-06-20T05:40:03Z

I could do a PR for this.
Automatic tests are failing but that is not a result of the change for this fix.

@noris666 Any suggestions?

elie222 · 2017-06-23T16:29:47Z

Or this: "react-native-meteor": "git://github.com/Nauzer/react-native-meteor.git",

jasonnathan · 2017-07-01T16:14:15Z

@Nauzer, I tried using your branch and I'm getting another error, this time for loginWithPassword. (I could start a new issue, but not sure if it's related & issues are disabled on your branch)

ExceptionsManager.js:63 _reactNativeMeteor2.default.loginWithPassword(...) is not a function

Switch to 'prop-types' instead of React.PropTypes Fix error 'db.batchUpdates undefined is not a function'. Issue #183

Nauzer · 2017-07-02T21:05:41Z

@jasonnathan i cant reproduce. Can you share your code?

Sent from my OnePlus ONEPLUS A3003 using FastHub

ujwal-setlur · 2017-07-02T21:18:53Z

Any hope this will get merged into the official repo? Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Nauzer <[email protected]> Sent: Sunday, July 2, 2017 2:05:42 PM To: inProgress-team/react-native-meteor Cc: Ujwal Setlur; Manual Subject: Re: [inProgress-team/react-native-meteor] Issue to update (#183) @jasonnathan<https://github.com/jasonnathan> i cant reproduce. Can you share your code? Sent from my OnePlus ONEPLUS A3003 using FastHub<https://play.google.com/store/apps/details?id=com.fastaccess.github> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#183 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AFkMXT-6cj52cSXJZm10viL4hNDKMNo1ks5sKAYmgaJpZM4LWbak>.

jasonnathan · 2017-07-03T01:38:47Z

Apologies @Nauzer, false alarm!

Nauzer · 2017-07-03T06:39:07Z

@ujwal-setlur It was already nerged. Will be pushed to npm somewhere today.

Sent from my OnePlus ONEPLUS A3003 using FastHub

ujwal-setlur · 2017-07-03T14:55:17Z

Awesome! Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Nauzer <[email protected]> Sent: Sunday, July 2, 2017 11:39:08 PM To: inProgress-team/react-native-meteor Cc: Ujwal Setlur; Mention Subject: Re: [inProgress-team/react-native-meteor] Issue to update (#183) @ujwal-setlur<https://github.com/ujwal-setlur> It was already nerged. Will be pushed to npm somewhere today. Sent from my OnePlus ONEPLUS A3003 using FastHub<https://play.google.com/store/apps/details?id=com.fastaccess.github> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#183 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AFkMXSGsutyiyaAmCfUjlKSdFE4eihSFks5sKIyMgaJpZM4LWbak>.

Nauzer · 2017-07-04T08:36:47Z

Merged to version 1.0.5. Closed.

Sent from my OnePlus ONEPLUS A3003 using FastHub

ujwal-setlur · 2017-07-04T15:59:06Z

Thanks! Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Nauzer <[email protected]> Sent: Tuesday, July 4, 2017 1:36:56 AM To: inProgress-team/react-native-meteor Cc: Ujwal Setlur; Mention Subject: Re: [inProgress-team/react-native-meteor] Issue to update (#183) Closed #183<#183>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#183 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AFkMXdPojGzcKFZ3yRKx1NI-Mk9amhsDks5sKfmogaJpZM4LWbak>.

charpeni · 2017-07-06T17:19:44Z

@Nauzer in [email protected], it has been renamed. 😓

-import ReactNative from 'react-native/Libraries/Renderer/src/renderers/native/ReactNative';
+import ReactNative from 'react-native/Libraries/Renderer/shims/ReactNative';

I'll send a PR.

Nauzer mentioned this issue Jun 13, 2017

ReactNative.unstable_batchedUpdates is undefined facebook/react-native#14490

Closed

Nauzer added a commit to Nauzer/react-native-meteor that referenced this issue Jun 20, 2017

Fix error 'db.batchUpdates undefined is not a function'. Issue inProg…

b4bc331

…ress-team#183.

Nauzer mentioned this issue Jun 28, 2017

Fix error 'db.batchUpdates undefined is not a function'. Issue #183. #244

Closed

Nauzer added a commit that referenced this issue Jul 2, 2017

Merge pull request #243 from coderafei/master

02e1c9f

Switch to 'prop-types' instead of React.PropTypes Fix error 'db.batchUpdates undefined is not a function'. Issue #183

Nauzer closed this as completed Jul 4, 2017

Issue to update #183

Issue to update #183

Comments

txs commented Dec 27, 2016 • edited by Nauzer Loading

spencercarli commented Dec 27, 2016

txs commented Dec 28, 2016

txs commented Dec 28, 2016

txs commented Dec 28, 2016

txs commented Jan 28, 2017

spencercarli commented Jan 29, 2017

txs commented Apr 18, 2017

turbobuilt commented May 11, 2017

txs commented May 13, 2017

txs commented May 13, 2017

txs commented May 13, 2017

txs commented May 15, 2017 via email

turbobuilt commented May 15, 2017

anhtuank7c commented Jun 8, 2017

txs commented Jun 8, 2017 via email

anhtuank7c commented Jun 8, 2017 • edited Loading

steven-tib commented Jun 9, 2017

anhtuank7c commented Jun 9, 2017

steven-tib commented Jun 9, 2017

Nauzer commented Jun 9, 2017 • edited Loading

wenzelmkay commented Jun 12, 2017

Nauzer commented Jun 12, 2017

Nauzer commented Jun 13, 2017

Nauzer commented Jun 13, 2017 • edited Loading

steven-tib commented Jun 13, 2017

spencercarli commented Jun 13, 2017

Nauzer commented Jun 13, 2017

spencercarli commented Jun 13, 2017

Nauzer commented Jun 13, 2017 • edited Loading

spencercarli commented Jun 13, 2017

edmundkwok commented Jun 14, 2017

Nauzer commented Jun 14, 2017

edmundkwok commented Jun 14, 2017 • edited Loading

wenzelmkay commented Jun 15, 2017 • edited Loading

Nauzer commented Jun 15, 2017 • edited Loading

abser commented Jun 16, 2017

ujwal-setlur commented Jun 20, 2017

ujwal-setlur commented Jun 20, 2017

Nauzer commented Jun 20, 2017

elie222 commented Jun 23, 2017

jasonnathan commented Jul 1, 2017

Nauzer commented Jul 2, 2017

ujwal-setlur commented Jul 2, 2017 via email

jasonnathan commented Jul 3, 2017

Nauzer commented Jul 3, 2017

ujwal-setlur commented Jul 3, 2017 via email

Nauzer commented Jul 4, 2017

ujwal-setlur commented Jul 4, 2017 via email

charpeni commented Jul 6, 2017

txs commented Dec 27, 2016 •

edited by Nauzer

Loading

anhtuank7c commented Jun 8, 2017 •

edited

Loading

Nauzer commented Jun 9, 2017 •

edited

Loading

Nauzer commented Jun 13, 2017 •

edited

Loading

Nauzer commented Jun 13, 2017 •

edited

Loading

edmundkwok commented Jun 14, 2017 •

edited

Loading

wenzelmkay commented Jun 15, 2017 •

edited

Loading

Nauzer commented Jun 15, 2017 •

edited

Loading