Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Add autocomplete attribute to form fields #620

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

markusguenther
Copy link

For accessibility reasons form elements should have autocomplete fields.
To have just autocomplete with value on or off does not bring much value for the user.

So form editors should be able to define the field content type so that the auto complete knows which data could be used.

Screenshot 2020-10-27 at 15 22 12

Screenshot 2020-10-27 at 15 24 12

@markusguenther
Copy link
Author

markusguenther commented Oct 27, 2020

Ah ok added that for version 7.4 ... so need to rebase that for the current develop branch.
I also need to add more german labels.

For accessibility reasons form elements should have autocomplete fields.
To have just autocomplete with value on or off does not bring much value for the user.

So form editors should be able to define the field content type so that the auto complete knows which data could be used.
@masi
Copy link

masi commented Nov 12, 2020

Wow, great work!

From a UI standpoint it would be a bit nicer if the name/telephone/address/birthday/cc-expiry parts were in a kind of submenu or otherwise visually separated.

I don't undertstand why name is duplicated in the CC section. IMHO this is confusing.

Nitpick: There is no way to select home/work/fax/pager for a phone number. Nor is there a way to mark a field belonging to a shipping or delivery address.

@markusguenther
Copy link
Author

Thanks for the feedback... right now I just checked what kind of autocomplete attributes are defined by the w3c and tried to group them.

Need to check if your requests are possible. T

@masi
Copy link

masi commented Nov 12, 2020

https://www.w3.org/TR/html52/sec-forms.html#sec-autofill

It's rarely referenced in tutorials, but the autocomplete attribute may be made of more than one token.

@ursbraem
Copy link
Contributor

ursbraem commented Sep 1, 2021

Will this be merged? That is a great feature!

@blueamerican
Copy link

I also have a feature request from a customer for the autocomplete field.

It would be great, if this could be merged.

@emileblume
Copy link

@einpraegsam Still nothing? What's needed to get this into production?

@ursbraem
Copy link
Contributor

ursbraem commented Nov 7, 2023

We have an extension with various tweaks to powermail, powermail_tools.
https://bitbucket.org/stubr/powermail_tools
It has autocomplete, and other very helpful features, check out the readme.
We haven't officially open sourced it, but maybe that's a good moment?

@emileblume
Copy link

We have an extension with various tweaks to powermail, powermail_tools. https://bitbucket.org/stubr/powermail_tools It has autocomplete, and other very helpful features, check out the readme. We haven't officially open sourced it, but maybe that's a good moment?

The addition of a standard solution for the autocomplete is long overdue and I really don't understand why Markus' feature is being ignored for so long. However I don't want to have to rely on additional extensions, especially since I have a work-around.

@ursbraem
Copy link
Contributor

ursbraem commented Nov 7, 2023

You're welcome :-)

@sypets
Copy link
Contributor

sypets commented Nov 8, 2023

@emileblume

However I don't want to have to rely on additional extensions, especially since I have a work-around.

What work-around?

@emileblume
Copy link

@sypets We never use the Placeholder field so editors get instructions to add the proper value for the autocomplete here.
In the Fluid partial Form > Field > Input I use this as the form.textfield tag.

<f:form.textfield type="{vh:validation.fieldTypeFromValidation(field:field)}" property="{field.marker}" value="{vh:misc.prefillField(field:field, mail:mail)}" class="powermail_input {settings.styles.framework.fieldClasses} {vh:validation.errorClass(field:field, class:'powermail_field_error')}" additionalAttributes="{vh:Validation.ValidationDataAttribute(field:field, additionalAttributes:'{autocomplete:\'{field.placeholder}\'}')}" id="powermail_field_{field.marker}" />

@mschwemer mschwemer deleted the branch in2code-de:master December 28, 2023 10:19
@mschwemer mschwemer closed this Dec 28, 2023
@mschwemer mschwemer reopened this Dec 28, 2023
@lorenzulrich
Copy link

@einpraegsam @mschwemer We opened this PR four years ago and there has not been any "official" feedback about it since then. As the patch doesn't apply anymore, we're unsure whether to rebase it or drop it because it isn't worth the work if it's not merged anyway.

Is there anything in particular that prevented you from commenting on it or is it just the lack of time? Thanks for a quick feedback.

@mschwemer
Copy link
Collaborator

@lorenzulrich This was a lack of time. I got some time to work on powermail on a weekly basis now.

If you would rebase it for powermail v12, that would be great and I will merge it in one of the next versions.

TIA

@mschwemer mschwemer changed the base branch from develop to master October 2, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants