-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: Add autocomplete attribute to form fields #620
base: master
Are you sure you want to change the base?
FEATURE: Add autocomplete attribute to form fields #620
Conversation
|
For accessibility reasons form elements should have autocomplete fields. To have just autocomplete with value on or off does not bring much value for the user. So form editors should be able to define the field content type so that the auto complete knows which data could be used.
f4830f1
to
53c0b5f
Compare
Wow, great work! From a UI standpoint it would be a bit nicer if the name/telephone/address/birthday/cc-expiry parts were in a kind of submenu or otherwise visually separated. I don't undertstand why name is duplicated in the CC section. IMHO this is confusing. Nitpick: There is no way to select home/work/fax/pager for a phone number. Nor is there a way to mark a field belonging to a shipping or delivery address. |
Thanks for the feedback... right now I just checked what kind of autocomplete attributes are defined by the w3c and tried to group them. Need to check if your requests are possible. T |
https://www.w3.org/TR/html52/sec-forms.html#sec-autofill It's rarely referenced in tutorials, but the autocomplete attribute may be made of more than one token. |
Will this be merged? That is a great feature! |
I also have a feature request from a customer for the autocomplete field. It would be great, if this could be merged. |
a31ca4e
to
43b5957
Compare
@einpraegsam Still nothing? What's needed to get this into production? |
We have an extension with various tweaks to powermail, |
The addition of a standard solution for the autocomplete is long overdue and I really don't understand why Markus' feature is being ignored for so long. However I don't want to have to rely on additional extensions, especially since I have a work-around. |
You're welcome :-) |
What work-around? |
@sypets We never use the Placeholder field so editors get instructions to add the proper value for the autocomplete here.
|
@einpraegsam @mschwemer We opened this PR four years ago and there has not been any "official" feedback about it since then. As the patch doesn't apply anymore, we're unsure whether to rebase it or drop it because it isn't worth the work if it's not merged anyway. Is there anything in particular that prevented you from commenting on it or is it just the lack of time? Thanks for a quick feedback. |
@lorenzulrich This was a lack of time. I got some time to work on powermail on a weekly basis now. If you would rebase it for powermail v12, that would be great and I will merge it in one of the next versions. TIA |
For accessibility reasons form elements should have autocomplete fields.
To have just autocomplete with value on or off does not bring much value for the user.
So form editors should be able to define the field content type so that the auto complete knows which data could be used.