Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(getting-started): add information about slsa attestor #456

Merged
merged 5 commits into from
Jun 1, 2024

Conversation

rrey
Copy link
Contributor

@rrey rrey commented May 24, 2024

What this PR does / why we need it

This PR results in a short discussion on Slack.

The Provenance being the very first requirement from SLSA, it seems quite appropriate to mention how Witness helps achieve this easily.

Acceptance Criteria Met

  • Docs changes if needed
  • Testing changes if needed
  • All workflow checks passing (automatically enforced)
  • All review conversations resolved (automatically enforced)
  • DCO Sign-off

Special notes for your reviewer:

Copy link

netlify bot commented May 24, 2024

Deploy Preview for witness-project ready!

Name Link
🔨 Latest commit 5c1c1f1
🔍 Latest deploy log https://app.netlify.com/sites/witness-project/deploys/665aa8c6f46a7a00080717d0
😎 Deploy Preview https://deploy-preview-456--witness-project.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rrey rrey marked this pull request as draft May 24, 2024 12:11
@rrey
Copy link
Contributor Author

rrey commented May 24, 2024

Changing to draft to see if I find other issues while testing witness.
I'll remove the draft flag at the end of the day if I do not find anything else.

@rrey rrey force-pushed the doc-fix branch 3 times, most recently from 1a7ae28 to c986cb7 Compare May 24, 2024 14:04
@rrey rrey changed the title docs(getting-started): fix missing dot in file name docs(getting-started): add information about slsa attestor May 24, 2024
@rrey rrey marked this pull request as ready for review May 24, 2024 14:26
rrey and others added 5 commits May 31, 2024 23:51
The Provenance being the very first requirement from SLSA, it seems quite
appropriate to mention how Witness helps achieve this easily.

Signed-off-by: Rémi REY <[email protected]>
Co-authored-by: Matthias Glastra <[email protected]>
Signed-off-by: Rémi REY <[email protected]>
Copy link
Member

@jkjell jkjell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@jkjell jkjell merged commit f499ffb into in-toto:main Jun 1, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants