-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(getting-started): add information about slsa attestor #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for witness-project ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Changing to draft to see if I find other issues while testing witness. |
rrey
force-pushed
the
doc-fix
branch
3 times, most recently
from
May 24, 2024 14:04
1a7ae28
to
c986cb7
Compare
matglas
reviewed
May 24, 2024
rrey
changed the title
docs(getting-started): fix missing dot in file name
docs(getting-started): add information about slsa attestor
May 24, 2024
matglas
reviewed
May 24, 2024
rrey
commented
May 24, 2024
Signed-off-by: Rémi REY <[email protected]>
The Provenance being the very first requirement from SLSA, it seems quite appropriate to mention how Witness helps achieve this easily. Signed-off-by: Rémi REY <[email protected]>
Co-authored-by: Matthias Glastra <[email protected]> Signed-off-by: Rémi REY <[email protected]>
Signed-off-by: Rémi REY <[email protected]>
Signed-off-by: Rémi REY <[email protected]>
jkjell
approved these changes
Jun 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR results in a short discussion on Slack.
The Provenance being the very first requirement from SLSA, it seems quite appropriate to mention how Witness helps achieve this easily.
Acceptance Criteria Met
Special notes for your reviewer: