-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding functionality for dirhash in cli #436
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for witness-project ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
d3fcdb6
to
78188b8
Compare
16026a4
to
95d1c7e
Compare
@jkjell @ChaosInTheCRD I updated both PRs with the latest updates and added changes that we discussed during the Community call. Let me know if you see anything that still needs to be addressed. |
I need some help to figure out the cause of this test failure which is hard to pinpoint. @mikhailswift or @jkjell maybe you can help a bit here. Note this is the result when you run the code with the update from the go-witness library PR that belongs to it.
|
@jkjell @mikhailswift if the go-witness lib is updated in go.mod then this PR can be merged too and functionality can be completed. |
Waiting for release > 0.6.0 |
Signed-off-by: Matthias Glastra <[email protected]>
Signed-off-by: Matthias Glastra <[email protected]>
Signed-off-by: Matthias Glastra <[email protected]>
Signed-off-by: Matthias Glastra <[email protected]>
Signed-off-by: Matthias Glastra <[email protected]>
Signed-off-by: Matthias Glastra <[email protected]>
Signed-off-by: Matthias Glastra <[email protected]>
What this PR does / why we need it
Adding the dirhash-glob arguments
Which issue(s) this PR fixes (optional)
Depends on:
Fixes: #216 and in-toto/go-witness#65
Acceptance Criteria Met
Special notes for your reviewer:
Todo's