-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: syft attestor #167
feat: syft attestor #167
Conversation
fdfb79c
to
cc16c98
Compare
Pull Request Test Coverage Report for Build 2116089781
💛 - Coveralls |
cc16c98
to
6ec2d2b
Compare
the digest here is md5
is there a way to use whatever is in the attestation context. from the docs it looks like it should be configurable.
|
6ec2d2b
to
f11e00e
Compare
|
I'm doubtful that there is actually GPL'd code being compiled into Witness here. The first instance snyk finds is
open-containers/image-spec is licensed under Apache 2, the same as Witness and does not import golangci-lint anywhere in their go code, so we're not compiling in ours, either. I'll do a more thorough look through the rest but it seems like snyk is picking up image-spec's CI tools as part of the library. |
I also don't believe we're vulnerable to either of the vulnerabilities detected. the gin vulnerability is focused around gin's logging functionality -- which we're not using at all the opa vuln we're also not using -- we're using an unaffected version of opa for our rego evaluation. |
I did try replacing gin with a newer version, seemed to compile. |
48f3c02
to
44791fe
Compare
go mod graph is not showing any versions of opa below 0.37 which doesn't have that CVE. go mod graph is not showing rapid as being part of our project -- it seems like a test library so I'm guessing some dependency uses it in their tests. anchore/go-version is MPL. MPL isn't viral like GPL and is only concerned with modifications to the MPL code -- which we're not doing and witness is open source, so any modifications would be freely available here. |
I'll look into the hashing stuff in a bit. |
👋 what's the plan for this PR to be merged in? We have a PR in Zarf pointing to a commit hash in this PR. Thanks! |
Adds an attestor that creates a SBOM using syft for a provided source or an automatically detected image tar file from the context's products. Signed-off-by: Mikhail Swift <[email protected]>
44791fe
to
ae9621d
Compare
This will be merged in today |
I have some issues about the dependencies we are pulling in here -- this is a good short term fix, however, we need to bring SBOM functionality in-tree |
yes as we've discussed. |
Adds an attestor that creates a SBOM using syft for a provided source or
an automatically detected image tar file from the context's products.
Signed-off-by: Mikhail Swift [email protected]