-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Go validator APIs for Provenance v1 predicate #287
Merged
TomHennen
merged 4 commits into
in-toto:main
from
marcelamelara:add-provenance-validators
Oct 13, 2023
Merged
Add Go validator APIs for Provenance v1 predicate #287
TomHennen
merged 4 commits into
in-toto:main
from
marcelamelara:add-provenance-validators
Oct 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelamelara
force-pushed
the
add-provenance-validators
branch
from
September 25, 2023 19:05
aedbff9
to
43f3d9b
Compare
pxp928
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nits else LGTM
Signed-off-by: Marcela Melara <[email protected]>
Signed-off-by: Marcela Melara <[email protected]>
Signed-off-by: Marcela Melara <[email protected]>
Signed-off-by: Marcela Melara <[email protected]>
marcelamelara
force-pushed
the
add-provenance-validators
branch
from
October 10, 2023 14:53
5aea664
to
6a10854
Compare
TomHennen
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Validate() functions for the SLSA Provenance v1 Go bindings, per the SLSA Provenance v1 spec, as well as basic tests.
Note: This PR is a blocker for ITE-6/ITE-9 integration in in-toto-golang: in-toto/in-toto-golang#268.