Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add predicate specification for CycloneDX #129

Merged
merged 3 commits into from
Mar 28, 2023

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Feb 2, 2023

This commit adds a predicate specification for CycloneDX using the example specification from issue #82.

The motivation for doing this is only to offer help with getting this into in-toto, in case the original author currently does not have time.

Co-authored-by: samj1912 [email protected]
Resolves: #82

Signed-off-by: Daniel Bevenius [email protected]

@adityasaky adityasaky requested a review from a team February 3, 2023 17:00
@marcelamelara
Copy link
Contributor

Thanks for this PR @danbev! Could you please make sure to write up your proposed predicate in ITE-9 formatting guidelines?

A separate question, how large do you expect CycloneDX predicates to be in practice? We do want to consider scalability of attestations as well.

@danbev
Copy link
Contributor Author

danbev commented Feb 4, 2023

Could you please make sure to write up your proposed predicate in ITE-9 formatting guidelines?

Sorry about that, for some reason I though it was in that format. I'll take a look at this next week and update 👍

@danbev
Copy link
Contributor Author

danbev commented Feb 6, 2023

A separate question, how large do you expect CycloneDX predicates to be in practice? We do want to consider scalability of attestations as well.

I'm afraid I don't know the answer to this question as I have very little practical experience with CycloneDX. Hopefully others can chime in that do have experience.

Copy link
Member

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be good to go. It does reference the most up-to-date CDX schema as the predicate

spec/predicates/cyclonedx.md Outdated Show resolved Hide resolved
"subject": [{ ... }],

// Predicate:
"predicateType": "https://cyclonedx.org/BOM",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it supposed to just be https://cyclonedx.org/bom? The page doesn't include the version (which I assume is embedded in the predicate field as it is for SPDX?

Copy link
Contributor

@marcelamelara marcelamelara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @danbev ! I have a few more change suggestions for clarity.

spec/predicates/cyclonedx.md Outdated Show resolved Hide resolved
spec/predicates/cyclonedx.md Outdated Show resolved Hide resolved
spec/predicates/cyclonedx.md Outdated Show resolved Hide resolved
spec/predicates/cyclonedx.md Outdated Show resolved Hide resolved
Copy link
Contributor

@marcelamelara marcelamelara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes, @danbev !

One more thing: Could you please add a link to the CycloneDX spec in the predicates list?

This commit adds a predicate specification for CycloneDX using the
example specification from issue in-toto#82.

The motivation for doing this is only to offer help with getting this
into in-toto, in case the original author currently does not have time.

Co-authored-by: samj1912 <[email protected]>
Resolves: in-toto#82

Signed-off-by: Daniel Bevenius <[email protected]>
Update list of vetted predicates.

Signed-off-by: Daniel Bevenius <[email protected]>
Copy link
Contributor

@TomHennen TomHennen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, generally looks good, just a couple small comments.

spec/predicates/README.md Show resolved Hide resolved
spec/predicates/cyclonedx.md Outdated Show resolved Hide resolved
Add link to README.md and remove tentative.

Signed-off-by: Daniel Bevenius <[email protected]>
Copy link
Member

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Cyclonedx as a predicate type
4 participants