Remove static muts from logging package #175
Conversation
Upcoming clippy versions have more agressive warnings about static mut, so I'm removing them from the logging package. The defmt frontend uses a custom static with interior mutability. The implementation is otherwise the same. I refactored the rest of the package to use `&'static mut`s produced by the static_cell package. This lets us remove the explicit uninitialized memory and the mutable statics. The details are unchanged. Tested the rtic_logging example on an 1170EVK: logging frontend with both backends, and the defmt frontend with just the LPUART frontend.
There was a problem hiding this comment.
This looks quite clean for the most part, and removing the statics seems to have made things nicer.
The enum and match done with Inner in Poller feels like it should be a generic parameter off hand, and not something I really looked hard at before. But I guess if you want to, at run time, switch from uart to usb cdc it makes sense, though most of the time I'd think this is a compile time decision to make?
|
It could be a compile-time decision, and most examples in this repo demonstrate backend selection based on a constant. But by representing a |
Upcoming clippy versions have more aggressive warnings about static mut, so I'm removing them from the logging package. The defmt frontend uses a custom static with interior mutability. The implementation is otherwise the same.
I refactored the rest of the package to use
&'static muts produced by the static_cell package. This lets us remove the explicit uninitialized memory and the mutable statics. The details are unchanged.Tested the rtic_logging example on an 1170EVK: logging frontend with both backends, and the defmt frontend with just the LPUART frontend.