Skip to content

Commit

Permalink
fix: footer jumping
Browse files Browse the repository at this point in the history
  • Loading branch information
imransilvake committed Dec 26, 2020
1 parent 9bae259 commit 895ca16
Show file tree
Hide file tree
Showing 3 changed files with 31 additions and 16 deletions.
33 changes: 18 additions & 15 deletions src/app/packages/frame.pck/components/footer/footer.component.html
Original file line number Diff line number Diff line change
@@ -1,16 +1,19 @@
<footer class="cd-container-fluid">
<div class="cd-container">
<section class="cd-row cd-center-align">
<div class="cd-col">
<h6>
<span>{{ footer['title'] | translate }}</span>
<img class="ik-angular"
[src]="'assets/svg/profile/expertise/angular.svg'"
[alt]="'angular'" />
<span></span>
<span class="ik-version">({{ appVersion }})</span>
</h6>
</div>
</section>
<footer [class.ik-hide]="!imageLoaded">
<div class="cd-container-fluid">
<div class="cd-container">
<section class="cd-row cd-center-align">
<div class="cd-col">
<h6>
<span>{{ footer['title'] | translate }}</span>
<img (load)="onLoadImage()"
class="ik-angular"
[src]="'assets/svg/profile/expertise/angular.svg'"
[alt]="'angular'" />
<span></span>
<span class="ik-version">({{ appVersion }})</span>
</h6>
</div>
</section>
</div>
</div>
</footer>
</footer>
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ footer {
background-color: var(--tc2);
border-top: 1px solid var(--tc7);

&.ik-hide {
display: none;
}

.cd-row {
padding: 10px 0;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,16 @@ import footer from '../../../../../assets/data/common/footer';
export class FooterComponent {
public footer = footer;
public appVersion;
public imageLoaded = false;

constructor(private _appVersionService: AppVersionService) {
this.appVersion = _appVersionService.getAppVersion;
this.appVersion = this._appVersionService.getAppVersion;
}

/**
* on image loaded
*/
public onLoadImage() {
this.imageLoaded = true;
}
}

0 comments on commit 895ca16

Please sign in to comment.