Implement Client Streaming and BiDi Streaming for grpc-web #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # examples/generated/examplecom/simple_service_pb_service.d.ts # examples/generated/proto/examplecom/simple_service_pb.d.ts # examples/generated/proto/examplecom/simple_service_pb.js # examples/generated/proto/examplecom/simple_service_pb_service.js # package.json # proto/examplecom/simple_service.proto # test/integration/service/grpcweb.ts
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
jonny-improbable
changed the title
|
@pjm17971 if could have some time to review that would be awesome, thanks! |
pjm17971
approved these changes
Sep 5, 2018
|
@pjm17971 If you can, could you please try upgrading to 0.7.7-pre.5959599 of ts-protoc-gen and give some feedback on how you get on? |
coltonmorris
pushed a commit
to coltonmorris/ts-protoc-gen
that referenced
this pull request
Oct 17, 2018
* upstream/master: Transport member of ServiceClientOptions should be optional (improbable-eng#125) Allow canceling unary calls (improbable-eng#124) CI should check that generated code has been committed (improbable-eng#127) Bumped to v0.7.8-pre (improbable-eng#123) Prepare 0.7.7 release (improbable-eng#112) Clean up Bazel Installation during Travis Build (improbable-eng#122) Don't deploy .deb files to npm (improbable-eng#121) Fix snake_cased oneof message are generated to incorrect types (improbable-eng#118) Make ServiceError optionally null (improbable-eng#116) Be explicit about the need for a CommonJS environment. (improbable-eng#108) Replace usage of `Object.assign` (improbable-eng#110) Add hint for Windows users (improbable-eng#107) Collapse Bazel Instructions in README (improbable-eng#106) Implement Client Streaming and BiDi Streaming for grpc-web (improbable-eng#82) Add support for jstype annotation (improbable-eng#104)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66
This PR provides support for both Client Streaming and BiDirectional Streaming to the generated service stubs.
As an additional drive-by, I've also provided support for debugging the tests using a connected Chrome Inspector/Debugger.