-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL changes after the whole transition animation is finished #367
Comments
Yes. It's how impress.js works. I don't know if that's that important when the URL changes. Of course, the action of changing happens when user hits the key, but the content of the slide is visible when animation finishes. And the reason it was done this way was a Chrome bug. When the URL was changing before the animation Chrome would store the history change during the animation and there was a (very visible) lag in the animation. Maybe the bug is fixed already and it could be changed, but I don't see the reason. If you have any reasons why it would be better to change the URL immediately let's talk about it. |
Well, my reason is that when jumping throught the slides fast I’d like to know where I am. And the URL shows the page number. But only after the animation has finished. So it’s either being fast or knowing where I am. If the Chrome didn’t exist any more there should be no reason to wait anymore, right? |
Action for this issue:
|
Wanted to call out the motivation for this request:
And also note that in 1.0.0 versions, there's also the progress bar and navigation menu that show the current slide (if enabled). However, they both share the same behavior: they update at the end of the animation. At least for the navigation ui, there's no reason it couldn't change earlier too. For progress bar, I think there's an animation that's intentional, and that would be lost. But speed is a good argument too. Even if changing the url would have some issue, as mentioned by @bartaz above, these UI controls can still change their behavior independent of that. |
This happens together with mdpress, I don’t know if that’s the case with all impress.js presentations.
I would be way snappier if the URL changed as soon as you hit a key for the next slide.
The text was updated successfully, but these errors were encountered: