Feature: add form id to multi step form template #7706
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially resolves GIVE-2091
Description
This adds the missing parity form ID
#give-next-gen
used by the classic form design to the multi-step form design. The reason is there are several gateways targeting the submit button using this form ID, which will result in unexpected behavior on multi-step form designs.Although the
give-next-gen
ID was not intentionally supposed to be used this way, it's important to be consistent. In the future, i'd like to revisit how we are targeting the submit button and offer a suggestion for gateways.Affects
Visuals
N/A
Testing Instructions
Zip: https://github.com/impress-org/givewp/actions/runs/13124037939
Let's QA a gateway like razorpay who is targeting the submit button this way
scrollIntoView
Pre-review Checklist
@unreleased
tags included in DocBlocks