Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add form id to multi step form template #7706

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Feb 3, 2025

Potentially resolves GIVE-2091

Description

This adds the missing parity form ID #give-next-gen used by the classic form design to the multi-step form design. The reason is there are several gateways targeting the submit button using this form ID, which will result in unexpected behavior on multi-step form designs.

Although the give-next-gen ID was not intentionally supposed to be used this way, it's important to be consistent. In the future, i'd like to revisit how we are targeting the submit button and offer a suggestion for gateways.

Affects

  • Multi-step enabled form designs & gateways targeting this ID (currently: paypal, blink, razorpay)

Visuals

N/A

Testing Instructions

Zip: https://github.com/impress-org/givewp/actions/runs/13124037939

Let's QA a gateway like razorpay who is targeting the submit button this way

  • Setup a v3 form using 2 column layout / multi-step
  • Make sure gateway goes through without any error about scrollIntoView

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein marked this pull request as ready for review February 3, 2025 22:23
@JoshuaHungDinh JoshuaHungDinh self-requested a review February 4, 2025 09:10
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parity achieved! Although something is going on with my Razorpay credentials so I was unable to test the gateway. If you can share some credentials I'll give it another go - otherwise maybe we can ask QA to double check for us.

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed QA tests.

@jonwaldstein jonwaldstein changed the base branch from master to develop February 7, 2025 14:45
@jonwaldstein jonwaldstein merged commit f39cd19 into develop Feb 7, 2025
20 checks passed
@jonwaldstein jonwaldstein deleted the feature/multi-step-form-id branch February 7, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants