Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: update regex check in give_clean #7704

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Refactor: update regex check in give_clean #7704

wants to merge 7 commits into from
+32 −1

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Jan 31, 2025 •
edited
Loading

Description

This updates our regex check in our trusty give_clean function to expand it's validation.

Affects

The give_clean() function

Visuals

N/A

Testing Instructions

TBD

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein changed the base branch from develop to master January 31, 2025 18:59
@jonwaldstein jonwaldstein changed the base branch from master to release/3.19.5 January 31, 2025 18:59
@jonwaldstein jonwaldstein changed the base branch from release/3.19.5 to develop January 31, 2025 19:09
@jonwaldstein jonwaldstein changed the base branch from develop to master February 3, 2025 19:48
@jonwaldstein jonwaldstein changed the title Refactor: elevate sanitization of data in give_clean Refactor: update regex check in give_clean Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glaubersilva glaubersilva Awaiting requested review from glaubersilva

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonwaldstein @glaubersilva