Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: adds the ability to override GiveWP website urls #7690

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

JasonTheAdams
Copy link
Contributor

@JasonTheAdams JasonTheAdams commented Jan 23, 2025

Description

This PR adds support for two new constants:

  • GIVE_SITE_URL
  • GIVE_LICENSE_API_URL

If these are defined, then they will be used in the licensing calls. This is useful for working on licensing changes and testing locally or on staging.

Affects

Licensing calls for validating and activating licenses

Testing Instructions

Mostly just make sure licensing still works properly. By default the constants don't exist, so nothing should really change.

Pre-review Checklist

  • Relevant @unreleased tags included in DocBlocks
  • Self Review of code and UX completed

Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and tested locally. Ready for QA 🌈

@JasonTheAdams
Copy link
Contributor Author

This has been QA'd by @lirianojoel and passed. Merging!

@JasonTheAdams JasonTheAdams merged commit 6a9d676 into develop Jan 27, 2025
21 checks passed
@JasonTheAdams JasonTheAdams deleted the feature/dynamic-licensing-urls branch January 27, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants