Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Explicitly execute script with PHP for Windows compatibility #7675

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

pulsovi
Copy link
Contributor

@pulsovi pulsovi commented Jan 15, 2025

fix: 'vendor\stellarwp\validation\bin\set-domain' is not recognized as an internal or external command, operable program or batch file.

Description

When I want to install the plugin on dev Windows setup, the composer install throws this issue :

> vendor/stellarwp/validation/bin/set-domain domain=give
'vendor\stellarwp\validation\bin\set-domain' is not recognized as an internal or external command, operable program or batch file.

Affects

Installation.

Testing Instructions

  1. On Windows setup
  2. git clone [email protected]:impress-org/givewp.git give
  3. cd give
  4. composer install

…s an internal or external command, operable program or batch file.
@pulsovi pulsovi force-pushed the windows-compatibility branch from 24fbec4 to bc3792b Compare January 15, 2025 18:25
@kjohnson kjohnson changed the title Fix: 'vendor\stellarwp\validation\bin\set-domain' is not recognized a… Fix: Explicitly execute script with PHP for Windows compatibility Jan 16, 2025
Copy link
Member

@kjohnson kjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I pulled it down and tested in a Linux enviroment just to double-check.

@kjohnson kjohnson merged commit 2ef835d into impress-org:develop Jan 16, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants