Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: add max rule to company field #7669

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Feature: add max rule to company field #7669

merged 1 commit into from
Jan 7, 2025

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Jan 7, 2025 •
edited by jira bot
Loading

Resolves GIVE-2080

Description

This adds a simple max character limit to the company field

Affects

The company field

Visuals

Screenshot 2025-01-07 at 10 35 43 AM

Testing Instructions

On a v3 form, try entering more than 255 characters into the company field.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein changed the base branch from develop to master January 7, 2025 15:38
@jonwaldstein jonwaldstein marked this pull request as ready for review January 7, 2025 15:38
glaubersilva
glaubersilva approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@glaubersilva glaubersilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonwaldstein Thanks! This is an important addition.

rickalday
rickalday approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed QA tests.

@jonwaldstein jonwaldstein changed the base branch from master to release/3.19.4 January 7, 2025 17:46
@jonwaldstein jonwaldstein merged commit 9ad3bdc into release/3.19.4 Jan 7, 2025
20 checks passed
@jonwaldstein jonwaldstein deleted the feature/company-field-validation branch January 7, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glaubersilva glaubersilva glaubersilva approved these changes

@rickalday rickalday rickalday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonwaldstein @rickalday @glaubersilva