Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: use email to get avatar URL #7667

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

glaubersilva
Copy link
Contributor

@glaubersilva glaubersilva commented Jan 6, 2025

Resolves GIVE-1165

Description

This PR change how we retrieve the donor avar URL in the Donor view, now instead of use the donor ID we are using the donor e-mail to make sure that the proper profile URL will be used.

As a note, the get_avatar_url() function, which is used under the hood, accepts the user e-mail or user id, so we were using it wrong before the changes implemented on this PR because the donor id is not the same one of the user id.

Affects

The donor's view.

Visuals

image

Testing Instructions

  1. Create a test donation using a donor's email that has a Gravatar account set up.
  2. Go to the donor's view page and make sure the proper avatar image (the same one from Gravatar) is displayed there.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@glaubersilva glaubersilva self-assigned this Jan 6, 2025
@glaubersilva glaubersilva marked this pull request as ready for review January 6, 2025 16:01
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed QA tests.

@glaubersilva glaubersilva merged commit 3c14973 into develop Jan 9, 2025
20 checks passed
@glaubersilva glaubersilva deleted the fix/donor-avatar-GIVE-1165 branch January 9, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants