Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: adds a css class for the form design #7665

Merged
merged 3 commits into from
Jan 3, 2025

Conversation

JasonTheAdams
Copy link
Contributor

@JasonTheAdams JasonTheAdams commented Jan 3, 2025

Description

This humble PR adds a class to the root div of a v3 form with the Form Design ID. Something like: givewp-donation-form-design--classic. It's purpose is so that when folks add custom styles (especially globally via code) they can use CSS to apply styles to only certain form designs.

Affects

V3 form rendering

Testing Instructions

  1. Make a form
  2. View the form on the front-end
  3. Check the root div for the Form Design class — it should correspond to your selected Form Design
  4. Switch Form Designs and check again

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Self Review of code and UX completed

Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! ⭐

@JasonTheAdams JasonTheAdams merged commit 38bb1f5 into develop Jan 3, 2025
20 checks passed
@JasonTheAdams JasonTheAdams deleted the feature/form-design-class branch January 3, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants