-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: hide gateways when donation amount is zero #7599
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
jonwaldstein
changed the title
Feature: hide gateways when minimum donation amount is not reached
Feature: hide gateways when donation amount is zero
Jan 17, 2025
kjohnson
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Do we need to run the design by Jeffrey?
rickalday
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed manual QA tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GIVE-2118
Description
This hides gateways when the donation amount is zero. This is primarily a precautionary measure to avoid errors with gateways as there is no reason to display a gateway when there is no amount. It's purely a visual update to prevent gateways from rendering in this scenario. It does not actually prevent the form from submitting, which will let the validation framework take over.
Related: #7515
In the future, our forms may be more flexible in creating something that does not equate to an amount. However, at this time all our gateways require an amount.
Affects
The v3 donation form gateway options
Visuals
Testing Instructions
Enter $0 in the custom amount field and scroll to the gateway options, you should be presented with a message instead of gateways.
Zip: https://github.com/impress-org/givewp/actions/runs/12912508739
Pre-review Checklist
@unreleased
tags included in DocBlocks