Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: hide gateways when donation amount is zero #7599

Merged
merged 12 commits into from
Jan 24, 2025

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Oct 31, 2024

Resolves GIVE-2118

Description

This hides gateways when the donation amount is zero. This is primarily a precautionary measure to avoid errors with gateways as there is no reason to display a gateway when there is no amount. It's purely a visual update to prevent gateways from rendering in this scenario. It does not actually prevent the form from submitting, which will let the validation framework take over.

Related: #7515

In the future, our forms may be more flexible in creating something that does not equate to an amount. However, at this time all our gateways require an amount.

Affects

The v3 donation form gateway options

Visuals

Screenshot 2025-01-17 at 1 38 44 PM

Testing Instructions

Enter $0 in the custom amount field and scroll to the gateway options, you should be presented with a message instead of gateways.

Zip: https://github.com/impress-org/givewp/actions/runs/12912508739

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein changed the title Feature: hide gateways when minimum donation amount is not reached Feature: hide gateways when donation amount is zero Jan 17, 2025
@jonwaldstein jonwaldstein marked this pull request as ready for review January 17, 2025 18:47
@kjohnson kjohnson self-requested a review January 21, 2025 16:15
Copy link
Member

@kjohnson kjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Do we need to run the design by Jeffrey?

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@jonwaldstein jonwaldstein merged commit 2ce51ba into develop Jan 24, 2025
21 checks passed
@jonwaldstein jonwaldstein deleted the feature/filter-gateways-zero-amount branch January 24, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants