Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: add additional validations for name title prefix field #7563

Merged
merged 4 commits into from
Oct 4, 2024
Merged

Enhancement: add additional validations for name title prefix field #7563

merged 4 commits into from
Oct 4, 2024

Conversation

glaubersilva
Copy link
Contributor

@glaubersilva glaubersilva commented Oct 4, 2024 •
edited by jira bot
Loading

Resolves GIVE-1289

Description

This PR implements a defensive approach to always check if the name title prefix is enabled on the form before accepting its values on the form submission.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@glaubersilva glaubersilva mentioned this pull request Oct 4, 2024
Closed
5 tasks
@glaubersilva glaubersilva self-assigned this Oct 4, 2024
@glaubersilva glaubersilva marked this pull request as ready for review October 4, 2024 17:46
jonwaldstein
jonwaldstein requested changes Oct 4, 2024
View reviewed changes
includes/process-donation.php Outdated Show resolved Hide resolved
includes/process-donation.php Outdated Show resolved Hide resolved
jonwaldstein
jonwaldstein approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

rickalday
rickalday approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@jonwaldstein jonwaldstein changed the base branch from master to release/3.16.3 October 4, 2024 21:36
@jonwaldstein jonwaldstein merged commit 5ab4e64 into release/3.16.3 Oct 4, 2024
20 checks passed
@jonwaldstein jonwaldstein deleted the enhancement/name-fields-validations-GIVE-1289 branch October 4, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickalday rickalday rickalday approved these changes

@jonwaldstein jonwaldstein jonwaldstein approved these changes

Assignees

@glaubersilva glaubersilva

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glaubersilva @rickalday @jonwaldstein