Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: the "Offline donations" section in the controls of the Payment Gateways block should be visible when Offline gateway for v3 forms is enabled #7492

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

glaubersilva
Copy link
Contributor

@glaubersilva glaubersilva commented Aug 20, 2024

Resolves GIVE-1106

Description

The problem was happening because we were checking if the offline gateway for v2 forms was enabled instead of checking the offline gateway for v3 forms.

Now we changed it to check the v3 version and the problem is not happening anymore.

Affects

The Payment Gateways block.

Visuals

image

Testing Instructions

  1. Disable the offline gateway for v2 forms;
  2. Enable the offline gateway for v3 forms;
  3. Go to the form builder and make sure the "Offline donations" section is visible in the controls of the Payment Gateways block settings.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@glaubersilva glaubersilva self-assigned this Aug 20, 2024
@glaubersilva glaubersilva marked this pull request as ready for review August 20, 2024 12:47
@glaubersilva glaubersilva requested a review from kjohnson August 20, 2024 12:48
Copy link
Member

@kjohnson kjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough. Looks good to me.

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@glaubersilva glaubersilva merged commit 3fb43fb into develop Aug 31, 2024
20 checks passed
@glaubersilva glaubersilva deleted the fix/offline-gateway-v3-forms-GIVE-1106 branch August 31, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants