Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Header image should show in Form Grid and link previews #7489

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

alaca
Copy link
Member

@alaca alaca commented Aug 16, 2024

Description

This PR resolves the issue with the featured image not showing in the form grid for v3 forms. Also, a new action is added to print form meta tags (og:image) to show an image preview for shared links.

Affects

Form grid
Donation form

Testing Instructions

Create v2 form and v3 form
Set featured/header image for both
Create a new page and add a Form Grid block
Verify that both forms show featured/header image

Pre-review Checklist

  • Relevant @unreleased tags included in DocBlocks
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein self-requested a review August 16, 2024 13:08
Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! ready for QA 🌈

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@jonwaldstein jonwaldstein merged commit 02a5b56 into develop Aug 23, 2024
20 checks passed
@jonwaldstein jonwaldstein deleted the feature/show-header-image-GIVE-915 branch August 23, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants