Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: persists "Supported Gateways" field on the settings of the "Subscription Payment Failed" email #7479

Merged

Conversation

glaubersilva
Copy link
Contributor

@glaubersilva glaubersilva commented Aug 5, 2024

Resolves GIVE-789

Description

This PR fixes a bug that prevents the "Supported Gateways" field be saved on the settings of the "Subscription Payment Failed" email. The problem was introduced in the following PR: #6237

So, the solution was to change how to set the "selected" attribute of the select options to make it work in the same way as before the changes introduced in the PR mentioned above.

Affects

The multiselect fields spread on the codebase.

Visuals

https://www.loom.com/share/6eabb134dc0940ec8af9d893d079ac9c?sid=e68abf36-b943-40ed-b512-9ade95bbfa95

Testing Instructions

  1. Go to Give > Settings > Emails > Subscription Payment Failed page;
  2. On the "Supported Gateways" field select a few gateways;
  3. Save the changes and make sure the selected gateways are saved.

Additional test: Please, follow the test instructions from this related PR and make sure the changes introduced there keep working as before.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@glaubersilva glaubersilva self-assigned this Aug 5, 2024
@glaubersilva glaubersilva changed the title Fix: persists "Supported Gateways" field on the settings of the subscription payment failed email Fix: persists "Supported Gateways" field on the settings of the "Subscription Payment Failed" email Aug 6, 2024
@glaubersilva glaubersilva marked this pull request as ready for review August 6, 2024 13:37
@glaubersilva glaubersilva requested a review from alaca August 6, 2024 13:37
Copy link
Member

@alaca alaca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@glaubersilva glaubersilva merged commit 95bd1fb into develop Aug 26, 2024
20 checks passed
@glaubersilva glaubersilva deleted the fix/subscription-failed-email-gateways-field-GIVE-789 branch August 26, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants