Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: update avatar route to check author of attachment #7476

Merged
merged 5 commits into from
Aug 7, 2024

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Aug 5, 2024

Resolves GIVE-983

Description

This updates the avatar route to check the author of attachment before deleting.

Affects

The avatar image upload functionality within the donor dashboard.

Visuals

N/A

Testing Instructions

Zip: https://github.com/impress-org/givewp/actions/runs/10254847235

Instructions are in Jira.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein changed the base branch from develop to master August 5, 2024 14:51
@jonwaldstein jonwaldstein requested a review from kjohnson August 5, 2024 15:01
Copy link
Member

@kjohnson kjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonwaldstein can you add a test for this?

src/DonorDashboards/Tabs/EditProfileTab/AvatarRoute.php Outdated Show resolved Hide resolved
src/DonorDashboards/Tabs/EditProfileTab/AvatarRoute.php Outdated Show resolved Hide resolved
@jonwaldstein jonwaldstein requested a review from kjohnson August 5, 2024 17:38
@jonwaldstein
Copy link
Contributor Author

@kjohnson thanks for the feedback, this has been updated and ready for re-review.

Copy link
Member

@kjohnson kjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonwaldstein jonwaldstein merged commit a38b14c into master Aug 7, 2024
20 checks passed
@jonwaldstein jonwaldstein deleted the fix/GIVE-983 branch August 7, 2024 12:41
kjohnson pushed a commit that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants