-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: change "Add Form" button link and styles #7462
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!
@jdghinson Currently, the buttons are being styled slightly different from WP native buttons (32px vs 30px height and 500 vs 400 font-weight). Was that intentional? |
@pauloiankoski Yes, the native looks smaller. |
src/Views/Components/ListTable/ListTablePage/ListTablePage.module.scss
Outdated
Show resolved
Hide resolved
@pauloiankoski This is ready for re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed manual QA tests.
Resolves GIVE-999
Description
This PR makes the "Add Form" button from the form list view create a new form using the visual form builder. It also updates the styles to keep the consistency with the WordPress secondary and primary buttons.
Affects
The "Add Form" button from the form list view.
Visuals
https://www.loom.com/share/caff9f3671eb4defab5b470e391ae55e?sid=e9fee7e0-7817-4af9-ae05-1d9228918d74
Testing Instructions
Give > All Forms
and make sure the new styles are applied to the buttons;User > Profile
and change the admin color scheme;Pre-review Checklist
@unreleased
tags included in DocBlocks