Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ensure global setting links open in a new tab #7400

Merged
merged 5 commits into from
Jun 24, 2024

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented May 30, 2024

Resolves: GIVE-813

Description

Some v3 block settings have the option to use global settings for the block. When global settings have been chosen, a link that navigates the user to the blocks settings page is shown. clicking this link can be frustrating if you are editing a form as it will navigate you from the builder to the settings page & you will lose any changes in progress.

The terms & conditions block + the donor name block both have this global setting link. This PR updates the anchor tags target and rel attributes to ensure they open the settings in a new tab. We also update the text within the link to capitalize the g in Global.

Affects

Donor Name Block
Terms & Conditions Block

Visuals

https://www.loom.com/share/197392b48ef341ae81b0f0535b18461c?sid=9af685c8-f528-43ee-a32c-a6f5f9653e12

Testing Instructions

  • Create a v3 form
  • Add the Terms & Conditions Block
  • Select the Terms & Conditions Block from the Build settings
  • Toggle the first setting
  • Click the link under the global settings selector from within the right sidebar
  • Verify it opens the global settings page in a new tab
  • Repeat steps with the Donor Name Block

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@JoshuaHungDinh JoshuaHungDinh marked this pull request as ready for review May 30, 2024 21:14
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes QA tests

@JoshuaHungDinh JoshuaHungDinh merged commit 995130a into develop Jun 24, 2024
20 checks passed
@JoshuaHungDinh JoshuaHungDinh deleted the refactor/global-setting-links branch June 24, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants