Fix: PayPal onboarding with email address that has plus sign #7393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 21, 2024 17:23
|
This PR is stale because it has been open 45 days with no activity. Stale PRs will NOT be automatically closed. |
|
This PR is stale because it has been open 45 days with no activity. Stale PRs will NOT be automatically closed. |
|
Build for QA, see https://github.com/impress-org/givewp/actions/runs/12203817090. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GIVE-800
Description
The PayPal onboarding query params are not encoded, yet we are handling them as if they were encoded by parsing them. The problematic query param is the
merchantId(email address) that could potentially have special character like a+sign. Ideally we would be able to encode that value before parsing it.This PR does a really simple
str_replaceon plus signs to convert them to the encoded character.Note: This has been reported to PayPal and they opened a ticket to investigate on there side. Their response was to handle the special characters on our end.
Affects
Paypal onboarding
Visuals
N/A
Testing Instructions
Pre-review Checklist
@unreleasedtags included in DocBlocks