Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Set recurring labels width on VFB #7359

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Fix: Set recurring labels width on VFB #7359

merged 1 commit into from
Apr 24, 2024

Conversation

pauloiankoski
Copy link
Contributor

@pauloiankoski pauloiankoski commented Apr 22, 2024 •
edited by jira bot
Loading

Resolves GIVE-645

Description

This pull-request fixes a visual issue with the recurring labels in the VFB. After the recent WordPress updates, they were no longer filling all the available space.

Affects

Recurring labels on VFB

Visuals

Before After
CleanShot 2024-04-22 at 11 03 59 CleanShot 2024-04-22 at 11 09 03

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

JoshuaHungDinh
JoshuaHungDinh approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, quick win!

rickalday
rickalday approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA test.

@pauloiankoski pauloiankoski merged commit c38700e into develop Apr 24, 2024
20 checks passed
@pauloiankoski pauloiankoski deleted the fix/amount-block-recurring-styles branch April 24, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickalday rickalday rickalday approved these changes

@JoshuaHungDinh JoshuaHungDinh JoshuaHungDinh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pauloiankoski @rickalday @JoshuaHungDinh