Fix: Set content for missing title in event tickets template #7323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open 45 days with no activity. Stale PRs will NOT be automatically closed. |
kjohnson
approved these changes
Dec 6, 2024
|
Build for QA, see https://github.com/impress-org/givewp/actions/runs/12203651394. |
|
@kjohnson thanks for reviving this! can you send it off to QA please? |
Base automatically changed from
epic/event-tickets-follow-up-GIVE-371
to
develop
January 13, 2025 20:06
pauloiankoski
force-pushed
the
fix/missing-tickets-list-component-title
branch
from
0cdd692 to
dffd534
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GIVE-2112
Description
Per designs, we have a title above the ticket list in the Event Tickets template, but due to a mistake in its implementation, it was being rendered as an empty tag. This pull request corrects this issue by directly setting its content in the template. As a consequence of this new implementation, all references to the
ticketLabelas an attribute are being removed.Visuals
Pre-review Checklist
@unreleasedtags included in DocBlocks