Epic/form UI column sorting

src/Donations/ServiceProvider.php

@@ -9,7 +9,6 @@
 use Give\Donations\LegacyListeners\InsertSequentialId;
 use Give\Donations\LegacyListeners\RemoveSequentialId;
 use Give\Donations\LegacyListeners\UpdateDonorPaymentIds;
-use Give\Donations\LegacyListeners\UpdateSequentialId;
 use Give\Donations\ListTable\DonationsListTable;
 use Give\Donations\Migrations\AddMissingDonorIdToDonationComments;
 use Give\Donations\Models\Donation;

src/Donors/ListTable/Columns/DonationCountColumn.php

@@ -15,7 +15,7 @@
 class DonationCountColumn extends ModelColumn
 {
 
-    protected $sortColumn = 'totalDonations';
+    protected $sortColumn = 'totalNumberOfDonations';
 
     /**
      * @unreleased

src/Subscriptions/Migrations/AddPaymentModeToSubscriptionTable.php

@@ -71,12 +71,10 @@ private function addPaymentModeColumn()
         $subscriptionTableName = "{$wpdb->prefix}give_subscriptions";
 
         try {
-            DB::query(
-                "
-                ALTER TABLE `$subscriptionTableName`
-                    ADD COLUMN `payment_mode` varchar(20) NOT NULL
-                    AFTER `parent_payment_id`;
-            "
+            maybe_add_column(
+                $subscriptionTableName,
+                'payment_mode',
+                "ALTER TABLE `$subscriptionTableName` ADD COLUMN `payment_mode` varchar(20) NOT NULL DEFAULT '' AFTER `parent_payment_id`"
             );
         } catch (DatabaseQueryException $exception) {
             throw new DatabaseMigrationException('An error occurred adding the payment mode column to the subscription table',

tests/Unit/DonationForms/DataTransferObjects/DonationFormQueryDataTest.php

@@ -1,13 +1,13 @@
 <?php
 
-namespace GiveTests\Unit\DonationForms\DataTransferObjects;
+namespace Give\Tests\Unit\DonationForms\DataTransferObjects;
 
 use Give\DonationForms\DataTransferObjects\DonationFormQueryData;
 use Give\DonationForms\ValueObjects\DonationFormMetaKeys;
 use Give\Framework\Database\DB;
-use GiveTests\TestCase;
-use GiveTests\TestTraits\RefreshDatabase;
-use GiveTests\Unit\DonationForms\TestTraits\LegacyDonationFormAdapter;
+use Give\Tests\TestCase;
+use Give\Tests\TestTraits\RefreshDatabase;
+use Give\Tests\Unit\DonationForms\TestTraits\LegacyDonationFormAdapter;
 
 final class DonationFormQueryDataTest extends TestCase
 {

tests/Unit/DonationForms/Endpoints/TestListDonationForms.php

@@ -1,13 +1,13 @@
 <?php
 
-namespace GiveTests\Unit\DonationForms\Endpoints;
+namespace Give\Tests\Unit\DonationForms\Endpoints;
 
 use Exception;
 use Give\DonationForms\Endpoints\ListDonationForms;
 use Give\DonationForms\ListTable\DonationFormsListTable;
-use GiveTests\TestCase;
-use GiveTests\TestTraits\RefreshDatabase;
-use GiveTests\Unit\DonationForms\TestTraits\LegacyDonationFormAdapter;
+use Give\Tests\TestCase;
+use Give\Tests\TestTraits\RefreshDatabase;
+use Give\Tests\Unit\DonationForms\TestTraits\LegacyDonationFormAdapter;
 use WP_REST_Request;
 use WP_REST_Server;
 

tests/Unit/DonationForms/Models/DonationFormTest.php

@@ -1,11 +1,11 @@
 <?php
 
-namespace GiveTests\Unit\DonationForms\DataTransferObjects;
+namespace Give\Tests\Unit\DonationForms\DataTransferObjects;
 
 use Give\DonationForms\Models\DonationForm;
-use GiveTests\TestCase;
-use GiveTests\TestTraits\RefreshDatabase;
-use GiveTests\Unit\DonationForms\TestTraits\LegacyDonationFormAdapter;
+use Give\Tests\TestCase;
+use Give\Tests\TestTraits\RefreshDatabase;
+use Give\Tests\Unit\DonationForms\TestTraits\LegacyDonationFormAdapter;
 
 final class DonationFormTest extends TestCase
 {

tests/Unit/DonationForms/TestTraits/LegacyDonationFormAdapter.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace GiveTests\Unit\DonationForms\TestTraits;
+namespace Give\Tests\Unit\DonationForms\TestTraits;
 
 use Give\DonationForms\Models\DonationForm;
 use Give\DonationForms\Properties\DonationFormLevel;

tests/Unit/Donations/Endpoints/TestListDonations.php

@@ -1,13 +1,13 @@
 <?php
 
-namespace GiveTests\Unit\Donations\Endpoints;
+namespace Give\Tests\Unit\Donations\Endpoints;
 
 use Exception;
 use Give\Donations\Endpoints\ListDonations;
 use Give\Donations\ListTable\DonationsListTable;
 use Give\Donations\Models\Donation;
-use GiveTests\TestCase;
-use GiveTests\TestTraits\RefreshDatabase;
+use Give\Tests\TestCase;
+use Give\Tests\TestTraits\RefreshDatabase;
 use WP_REST_Request;
 use WP_REST_Server;
 

tests/Unit/Donors/Endpoints/TestListDonors.php

@@ -1,13 +1,13 @@
 <?php
 
-namespace GiveTests\Unit\Donors\Endpoints;
+namespace Give\Tests\Unit\Donors\Endpoints;
 
 use Exception;
 use Give\Donors\Endpoints\ListDonors;
 use Give\Donors\ListTable\DonorsListTable;
 use Give\Donors\Models\Donor;
-use GiveTests\TestCase;
-use GiveTests\TestTraits\RefreshDatabase;
+use Give\Tests\TestCase;
+use Give\Tests\TestTraits\RefreshDatabase;
 use WP_REST_Request;
 use WP_REST_Server;
 

tests/Unit/Framework/QueryBuilder/AttachMetaTest.php

@@ -102,7 +102,7 @@ public function testConfigureMeta()
             ->where('donationMeta.custom_meta_value', 1);
 
         $this->assertContains(
-            "SELECT posts.ID AS id, posts.post_date AS createdAt, wp_give_donationmeta_attach_meta_amount.custom_meta_value AS amount FROM wp_posts AS posts LEFT JOIN wp_give_donationmeta wp_give_donationmeta_attach_meta_amount ON posts.ID = wp_give_donationmeta_attach_meta_0.donation_id AND wp_give_donationmeta_attach_meta_amount.custom_meta_key = '_give_payment_total' LEFT JOIN wp_give_donationmeta donationMeta ON posts.ID = donationMeta.donation_id WHERE posts.post_type = 'give_payment' AND posts.post_status = 'give_subscription' AND donationMeta.custom_meta_key = 'subscription_id' AND donationMeta.custom_meta_value = '1'",
+            "SELECT posts.ID AS id, posts.post_date AS createdAt, wp_give_donationmeta_attach_meta_amount.custom_meta_value AS amount FROM wp_posts AS posts LEFT JOIN wp_give_donationmeta wp_give_donationmeta_attach_meta_amount ON posts.ID = wp_give_donationmeta_attach_meta_amount.donation_id AND wp_give_donationmeta_attach_meta_amount.custom_meta_key = '_give_payment_total' LEFT JOIN wp_give_donationmeta donationMeta ON posts.ID = donationMeta.donation_id WHERE posts.post_type = 'give_payment' AND posts.post_status = 'give_subscription' AND donationMeta.custom_meta_key = 'subscription_id' AND donationMeta.custom_meta_value = '1'",
             $builder->getSQL()
         );
     }

tests/Unit/Framework/QueryBuilder/HavingTest.php

@@ -21,7 +21,7 @@ public function testHaving()
             ->having('id', '>', 10);
 
         $this->assertContains(
-            "SELECT * FROM posts WHERE post_parent = '5' GROUP BY id HAVING 'id' > '10'",
+            "SELECT * FROM posts WHERE post_parent = '5' GROUP BY id HAVING id > '10'",
             $builder->getSQL()
         );
     }

tests/Unit/Subscriptions/Endpoints/TestListSubscriptions.php

@@ -1,14 +1,14 @@
 <?php
 
-namespace GiveTests\Unit\Subscriptions\Endpoints;
+namespace Give\Tests\Unit\Subscriptions\Endpoints;
 
 use Exception;
 use Give\Subscriptions\Endpoints\ListSubscriptions;
 use Give\Subscriptions\ListTable\SubscriptionsListTable;
 use Give\Subscriptions\Models\Subscription;
 use Give\Subscriptions\ValueObjects\SubscriptionMode;
-use GiveTests\TestCase;
-use GiveTests\TestTraits\RefreshDatabase;
+use Give\Tests\TestCase;
+use Give\Tests\TestTraits\RefreshDatabase;
 use WP_REST_Request;
 use WP_REST_Server;