Skip to content
This repository has been archived by the owner on Oct 16, 2023. It is now read-only.

Feature: Add customer feedback popup #96

Merged
merged 6 commits into from
Nov 29, 2022
Merged

Conversation

kjohnson
Copy link
Contributor

@kjohnson kjohnson commented Nov 23, 2022

Description

This PR adds a customer feedback popup/button in the lower right of the form builder.

  • The button directs to the feedback URL in an new tab.
  • The link in the popup directs to the feedback URL in a new tab and marks the popup as hidden.
  • The close icon in the popup marks the popup as hidden.
  • Local browser storage is used to keep the popup hidden after use.

Affects

  • Adds bottom padding to the sidebar to avoid obstruction of sidebar settings.

Visuals

Screenshot of the Feedback Popup in the Form Builder
image


Recording of deleting the local browser storage.
Peek 2022-11-23 14-59


Recording of updated font size, weight, line height, and alignment.

Peek 2022-11-23 15-01

Testing Instructions

  • Delete the local storage item givewpNextGenHideFeedback to restore the popup.

@kjohnson kjohnson marked this pull request as ready for review November 23, 2022 16:13
Copy link

@jdghinson jdghinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good!

Content as PopupContent,
} from './popup'

const feedbackUrl = 'https://feedback.givewp.com/next-gen';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this url to our storageData from the server. It will just make it easier to update that Url if need be.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a URL that should not change - and if it did it would require a new release, which means a build. I'd rather maintain simplicity here as this component is temporary.

Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍿

@kjohnson kjohnson merged commit df3be6d into develop Nov 29, 2022
@kjohnson kjohnson deleted the feature/customer-feedback branch November 29, 2022 20:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants