Skip to content
This repository has been archived by the owner on Oct 16, 2023. It is now read-only.

Refactor: Move Donation Goal settings to the design tab #89

Merged
merged 11 commits into from
Nov 16, 2022
Merged

Refactor: Move Donation Goal settings to the design tab #89

merged 11 commits into from
Nov 16, 2022

Conversation

kjohnson
Copy link
Contributor

@kjohnson kjohnson commented Nov 11, 2022 •
edited
Loading

Description

  • Co-locates the Donation Goal settings to the Design Preview tab (in addition to the Form Settings tab).
  • Renames Goal Format to Goal Type.
  • Removes percentage-raised as a Goal Type

Visuals

image

@kjohnson kjohnson marked this pull request as ready for review November 14, 2022 16:35
@kjohnson kjohnson changed the title Add Donation Goal settings to the design tab Refactor: Move Donation Goal settings to the design tab Nov 14, 2022
jonwaldstein
jonwaldstein approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@kjohnson kjohnson merged commit f1a94a5 into develop Nov 16, 2022
@kjohnson kjohnson deleted the refactor/relocate-donation-goal-settings branch December 14, 2022 18:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JasonTheAdams JasonTheAdams JasonTheAdams left review comments

@jonwaldstein jonwaldstein jonwaldstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kjohnson @JasonTheAdams @jonwaldstein